Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: CSS #143

Open
sadiqkhoja opened this issue Jun 26, 2024 · 2 comments
Open

Refactor: CSS #143

sadiqkhoja opened this issue Jun 26, 2024 · 2 comments
Assignees
@sadiqkhoja

Comments

@sadiqkhoja
Copy link
Contributor

sadiqkhoja commented Jun 26, 2024 •
edited
Loading

  • Use rem instead of px in CSS specially for spacing.
  • PrimeVue has appendTo prop for components that injects elements to the DOM like dropdown, menu, etc. We can use self then we would not need to use :deep in our styling
@sadiqkhoja sadiqkhoja self-assigned this Jun 26, 2024
@sadiqkhoja sadiqkhoja changed the title Refactor CSS Refactor: CSS Jun 26, 2024
@sadiqkhoja sadiqkhoja mentioned this issue Jun 26, 2024
Merged
@lognaturel
Copy link
Member

Maybe it’s worth waiting for PrimeVue 4 to do this? I wonder whether it might be appropriate to use some of the tokens they define.

@sadiqkhoja
Copy link
Contributor Author

I was thinking the same that's why didn't added it in next milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadiqkhoja sadiqkhoja

Labels
None yet
Projects
Web Forms
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sadiqkhoja @lognaturel