Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle grpc server with controller-manager in the operator pod spec #308

Open
troy0820 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #332
Open

Bundle grpc server with controller-manager in the operator pod spec #308

troy0820 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #332
Assignees
@troy0820
Labels
design 🚲🏠 Bust out your paint chips, it's time to bikeshed. enhancement New code, ahoy! good first issue Good for new contributors user experience 🌈💖 All Hail the UX Gods

Comments

@troy0820
Copy link
Member

Is your feature request related to a problem? Please describe.
We have the capability to ship the grpc server along with the operator in one yaml instead of trying to drive them separately. Currently we do not ship the grpc server and it doesn't allow the installation outputs to work without them.

Describe the solution you'd like
Create the yaml that is going to be deployed and allow that to be used with the deployment of the operator. That deployment should include the grpc service to be used by the porter operator within the context of creating a porter operator. The binary for this we can create a generic grpc server and inject the service necessary as well as provide the service during deployment into the porter-operator namespace.

Describe alternatives you've considered
What is described above but this effort will have to come in phases as this will require that porter main can install this properly

Additional context
None
@troy0820 troy0820 added design 🚲🏠 Bust out your paint chips, it's time to bikeshed. enhancement New code, ahoy! user experience 🌈💖 All Hail the UX Gods labels Mar 12, 2024
@schristoff schristoff added the good first issue Good for new contributors label Apr 4, 2024
@schristoff schristoff moved this to Todo in v1.1.0 (June 2024) Apr 4, 2024
@troy0820
Copy link
Member Author

If we decide to have the controller create the deployment of the grpc server, we could do that but not when an installation is applied. This could happen on startup but I want to make sure that this is the direction we want to go in.

@troy0820 troy0820 linked a pull request Jun 20, 2024 that will close this issue
Open
6 tasks
@troy0820
Copy link
Member Author

The porter config is what drives the grpc server to save state. The dynamic creation of the grpc server needs to allow the porter config (if it exists) to be the backend storage of the grpc server. In resolvePorterConfig the backend is described by the mongodb deployment/service which can be used to settle the grpc server in each namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troy0820 troy0820

Labels
design 🚲🏠 Bust out your paint chips, it's time to bikeshed. enhancement New code, ahoy! good first issue Good for new contributors user experience 🌈💖 All Hail the UX Gods
Projects
v1.1.0 (June 2024)
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create grpc deployment when starting operator troy0820/operator
2 participants
@troy0820 @schristoff