You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The cnab adapter needs to be updated to support generating either v1 or v2 of the dependencies extension for inclusion in bundle.json. The first step is to just refactor the adapter so that it can differentiate between which extension it is working with.
I've already started this in #2099 but we need to split this out into a PR that just implements this new pattern for v1, so that we can incrementally add this feature into Porter. When we finally implement advanced dependencies in a later PR, then we should be able to update the adapter with the v2 logic, and the adapter will correctly handle generating either v1 or v2 depending on which the bundle is using.
The cnab adapter needs to be updated to support generating either v1 or v2 of the dependencies extension for inclusion in bundle.json. The first step is to just refactor the adapter so that it can differentiate between which extension it is working with.
I've already started this in #2099 but we need to split this out into a PR that just implements this new pattern for v1, so that we can incrementally add this feature into Porter. When we finally implement advanced dependencies in a later PR, then we should be able to update the adapter with the v2 logic, and the adapter will correctly handle generating either v1 or v2 depending on which the bundle is using.
porter/pkg/cnab/config-adapter/adapter.go
Lines 414 to 428 in 58dc1e8
The text was updated successfully, but these errors were encountered: