Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve a subset of values in a value set #2609

Open
Tracked by #2680
carolynvs opened this issue Mar 2, 2023 · 0 comments · May be fixed by #3301
Open
Tracked by #2680

Resolve a subset of values in a value set #2609

carolynvs opened this issue Mar 2, 2023 · 0 comments · May be fixed by #3301
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal performance 🏎💨 Tasks that improve the performance of Porter placeholder Tracks work that has not yet be fully designed security 🔒 Security issues, bugs and features

Comments

@carolynvs
Copy link
Member

carolynvs commented Mar 2, 2023

I would like to have dependent installations in a bundle dependency graph to be able to "reuse" a credential or parameter set referenced by the root bundle. So if the myenv installation has a credential set named "all the stuff" and one of its credentials is passed through the graph to mydb, then mydb should be able to reference the "all the stuff" credential set and when it's resolved before the bundle is run, we only resolve the credentials used by that bundle. This helps us avoid resolving the entire credential set, reducing external API calls and accessing sensitive data that wasn't needed.

We'll need to update our functions that resolve parameters and credential sets (value sets) to accept a list of keys to resolve and update all existing code paths to pass in the full set of keys.

Later when dependencies is implemented, we can then pass in a subset of keys that are used by the dependent bundle. So this is essentially a refactoring PR that we can commit against main immediately (and without a feature flag), and we will use it later when we need it to implement PEP003.

ℹ️ Read PEP003 - Advanced Dependencies for context about how dependencies should work, design details, and notes about desired behavior.

@carolynvs carolynvs added security 🔒 Security issues, bugs and features performance 🏎💨 Tasks that improve the performance of Porter pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal labels Mar 2, 2023
@carolynvs carolynvs added the placeholder Tracks work that has not yet be fully designed label Mar 31, 2023
@kichristensen kichristensen linked a pull request Dec 28, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pep003-advanced-dependencies Implementation of the Advanced Dependencies proposal performance 🏎💨 Tasks that improve the performance of Porter placeholder Tracks work that has not yet be fully designed security 🔒 Security issues, bugs and features
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant