-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multiple working dirs #115
Open
sgettys
wants to merge
7
commits into
getporter:main
Choose a base branch
from
sgettys:feat/add-multiple-working-dirs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgettys
changed the title
WIP:Feat/add multiple working dirs
WIP: Feat/add multiple working dirs
Mar 21, 2024
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
Signed-off-by: Steven Gettys <[email protected]>
sgettys
force-pushed
the
feat/add-multiple-working-dirs
branch
from
March 26, 2024 05:38
db4872a
to
66fade1
Compare
Signed-off-by: Steven Gettys <[email protected]>
sgettys
changed the title
WIP: Feat/add multiple working dirs
feat: add multiple working dirs
Mar 26, 2024
Refactor to have the build step inspect all actions for "workingDir" specified and collect them at build time. Fallback to the "workingDir" set in the mixin config or default |
aafaq-rashid-comprinno
approved these changes
May 8, 2024
schristoff
approved these changes
Nov 26, 2024
oop, @sgettys can you fix that test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
This adds the ability to specify multiple terraform plans based on different working directories. The mixin config can now specify a list of directories for the different working dirs. Then each step can specify the working dir for the run of that step.
Example mixin config
Example install step with working directory specified for the step:
Updated integration test with a multiple working dirs bundle.
Added usage docs.