Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not overriding symlink at release-registry when publishing #118

Closed
philipphofmann opened this issue Jul 22, 2020 · 1 comment
Closed

Not overriding symlink at release-registry when publishing #118

philipphofmann opened this issue Jul 22, 2020 · 1 comment

Comments

@philipphofmann
Copy link
Member

When the release-registry already contains a symlink for the specified version craft fails to publish the release. I would expect that it overrides the symlink with the JSON for the specified release.

Steps to reproduce with sentry-cocoa:

  1. craft prepare 5.1.10
  2. Create a symlink for 5.1.10.json in release-registry for cocoa.
  3. craft publish 5.1.10 --target registry
  4. Craft fails with Error: Version file for "5.1.10" already exists. Aborting.

Screenshot 2020-07-22 at 13 41 12

This is related to getsentry/sentry-release-registry#27

@tonyo
Copy link
Contributor

tonyo commented Jul 24, 2020

As mentioned in the offline discussion, this in not something we should change in craft, I believe. This error actually helped to uncover the issue we have with the tooling in release-registry.
@philipphofmann lmk if you still think that we should change this behavior.

@tonyo tonyo closed this as completed Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants