Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sampling Seed Propagation #2559

Open
kahest opened this issue Jan 8, 2025 · 1 comment · May be fixed by #2629
Open

Implement Sampling Seed Propagation #2559

kahest opened this issue Jan 8, 2025 · 1 comment · May be fixed by #2629
Assignees

Comments

@kahest
Copy link
Member

kahest commented Jan 8, 2025

Description

See https://github.com/getsentry/projects/issues/316

To increase the chance of capturing complete traces when users return a new sample rate tracesSampler in backend services, we propagate the random value used by the SDK for computing the sampling decision instead of creating a new random value in every service. Therefore, across a trace every SDK uses the same random value.

Develop: Spec

See also

Sample implemeantion in PHP getsentry/sentry-php#1793.

@buenaflor
Copy link
Contributor

tbd by end of feb latest

@buenaflor buenaflor self-assigned this Jan 27, 2025
@buenaflor buenaflor linked a pull request Jan 29, 2025 that will close this issue
6 tasks
@buenaflor buenaflor moved this from Todo to Needs Review in Mobile & Cross Platform SDK Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Review
Development

Successfully merging a pull request may close this issue.

2 participants