Reduce Sampling footprint in "Set Up Tracing" #10505
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewing this page I realized sentry warned me repeatedly about Sampling. The docs don't actually tell me why. Just have a blue info panel and a paragraph as part of the validation section, which actually that is a sub point, and nothing you can specifically "verify" I proposes this reduction
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
lizokm
reviewed
Jun 26, 2024
| If you leave your sample rate at `1.0`, a transaction will be sent every time a user loads a page or navigates within your app. Depending on the amount of traffic your application gets, this may mean a lot of transactions. If you have a high-load, backend application, you may want to consider setting a lower <PlatformIdentifier name="traces-sample-rate" /> value, or switching to using <PlatformIdentifier name="traces-sampler" /> to selectively sample and filter your transactions, based on contextual data. | ||
| ### Sampling | ||
|
|
||
| Leaving your sample rate at `1.0` means that traces will be started for every page load, navigation, and other events like function calls within your application. Depending on the amount of traffic your application gets, you may want to consider setting a lower <PlatformIdentifier name="traces-sample-rate" /> value, or switching to using <PlatformIdentifier name="traces-sampler" /> to selectively sample and filter your transactions. |
There was a problem hiding this comment.
Suggested change
| Leaving your sample rate at `1.0` means that traces will be started for every page load, navigation, and other events like function calls within your application. Depending on the amount of traffic your application gets, you may want to consider setting a lower <PlatformIdentifier name="traces-sample-rate" /> value, or switching to using <PlatformIdentifier name="traces-sampler" /> to selectively sample and filter your transactions. | |
| If you leave your sample rate at `1.0`, a trace will be started for every page load, navigation, and any other events like function calls within your application. Depending on the amount of traffic your application gets, you may want to consider setting a lower <PlatformIdentifier name="traces-sample-rate" /> value, or switching to using <PlatformIdentifier name="traces-sampler" /> to selectively sample and filter your transactions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing this page I realized sentry warned me repeatedly about Sampling. The docs don't actually tell me why. Just have a blue info panel and a paragraph as part of the validation section, which actually that is a sub point, and nothing you can specifically "verify"
I proposes this reduction
Also, i don't think the OTel instrumentation is really necessary top of the page, it is distracing IMO, and more relevant to next steps with custom instrumentation. We are explaining how the sausage is made, directing you to learn how to make your own, and no one has even tried the sausage yet