Skip to content

Commit 74100e9

Browse files
committed
Update integration tests
1 parent d1731d7 commit 74100e9

File tree

3 files changed

+11
-29
lines changed

3 files changed

+11
-29
lines changed

test_integrations/phoenix_app/test/phoenix_app/oban_test.exs

+1-8
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,6 @@ defmodule Sentry.Integrations.Phoenix.ObanTest do
3838
assert trace.data["oban.job.job_id"]
3939
assert trace.data["messaging.destination"] == "default"
4040
assert trace.data["oban.job.attempt"] == 1
41-
42-
assert [span] = transaction.spans
43-
44-
assert span.op == "queue.process"
45-
assert span.description == "Sentry.Integrations.Phoenix.ObanTest.TestWorker"
46-
assert span.data["oban.job.job_id"]
47-
assert span.data["messaging.destination"] == "default"
48-
assert span.data["oban.job.attempt"] == 1
41+
assert [] = transaction.spans
4942
end
5043
end

test_integrations/phoenix_app/test/phoenix_app_web/controllers/transaction_test.exs

+3-14
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,7 @@ defmodule Sentry.Integrations.Phoenix.TransactionTest do
2828
assert trace.op == "test_span"
2929
assert trace.data == %{}
3030

31-
assert [span] = transaction.spans
32-
33-
assert span.op == "test_span"
34-
assert span.trace_id == trace.trace_id
35-
refute span.parent_span_id
31+
assert [] = transaction.spans
3632
end
3733

3834
test "GET /users", %{conn: conn} do
@@ -52,10 +48,7 @@ defmodule Sentry.Integrations.Phoenix.TransactionTest do
5248
assert trace.op == "PhoenixAppWeb.UserLive.Index.mount"
5349
assert trace.data == %{}
5450

55-
assert [span_mount, span_ecto] = mount_transaction.spans
56-
57-
assert span_mount.op == "PhoenixAppWeb.UserLive.Index.mount"
58-
assert span_mount.description == "PhoenixAppWeb.UserLive.Index.mount"
51+
assert [span_ecto] = mount_transaction.spans
5952

6053
assert span_ecto.op == "db"
6154
assert span_ecto.description == "SELECT u0.\"id\", u0.\"name\", u0.\"age\", u0.\"inserted_at\", u0.\"updated_at\" FROM \"users\" AS u0"
@@ -67,10 +60,6 @@ defmodule Sentry.Integrations.Phoenix.TransactionTest do
6760
assert trace.origin == "opentelemetry_phoenix"
6861
assert trace.op == "PhoenixAppWeb.UserLive.Index.handle_params"
6962
assert trace.data == %{}
70-
71-
assert [span_handle_params] = handle_params_transaction.spans
72-
73-
assert span_handle_params.op == "PhoenixAppWeb.UserLive.Index.handle_params"
74-
assert span_handle_params.description == "PhoenixAppWeb.UserLive.Index.handle_params"
63+
assert [] = handle_params_transaction.spans
7564
end
7665
end

test_integrations/phoenix_app/test/phoenix_app_web/live/user_live_test.exs

+7-7
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ defmodule PhoenixAppWeb.UserLiveTest do
6464
assert transaction_save.contexts.trace.op == "PhoenixAppWeb.UserLive.Index.handle_event#save"
6565
assert transaction_save.contexts.trace.origin == "opentelemetry_phoenix"
6666

67-
assert length(transaction_save.spans) == 2
68-
assert [_span_1, span_2] = transaction_save.spans
69-
assert span_2.op == "db"
70-
assert span_2.description =~ "INSERT INTO \"users\""
71-
assert span_2.data["db.system"] == :sqlite
72-
assert span_2.data["db.type"] == :sql
73-
assert span_2.origin == "opentelemetry_ecto"
67+
assert length(transaction_save.spans) == 1
68+
assert [span] = transaction_save.spans
69+
assert span.op == "db"
70+
assert span.description =~ "INSERT INTO \"users\""
71+
assert span.data["db.system"] == :sqlite
72+
assert span.data["db.type"] == :sql
73+
assert span.origin == "opentelemetry_ecto"
7474
end
7575

7676
test "updates user in listing", %{conn: conn, user: user} do

0 commit comments

Comments
 (0)