Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] Remove non-normalized request handling in requestDataIntegration #14297

Open
mydea opened this issue Nov 14, 2024 · 0 comments · May be fixed by #14806
Open

[v9] Remove non-normalized request handling in requestDataIntegration #14297

mydea opened this issue Nov 14, 2024 · 0 comments · May be fixed by #14806
Assignees
@mydea
Milestone
9.0.0

Comments

@mydea
Copy link
Member

mydea commented Nov 14, 2024 •
edited
Loading

Description

Today, we have two ways to add request data to events in requestDataIntegration:

  1. Recently added via normalizedRequest on the SDK processing metadata, which is pre-processed
  2. The "old" way of request on the SDK processing metadata which is processed in the integration

In v9, we want to remove the old request variant, and only rely on the normalizedRequest.

Related to this, we may also clean up the types & type names for this.

Follow up to #14298
@lforst lforst added this to the 9.0.0 milestone Nov 14, 2024
@mydea mydea self-assigned this Dec 19, 2024
@mydea mydea linked a pull request Dec 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

feat: Update requestDataIntegration handling getsentry/sentry-javascript
2 participants
@mydea @lforst