Skip to content

Commit 97a5c08

Browse files
authored
tests: Move requests under toxgen (#4825)
### Description - Move requests under toxgen - This was the last test suite to port! 🎉 #### Issues ref #4506 #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
1 parent 222badb commit 97a5c08

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

scripts/populate_tox/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@
291291
},
292292
"requests": {
293293
"package": "requests",
294+
"num_versions": 2,
294295
},
295296
"rq": {
296297
"package": "rq",

scripts/populate_tox/populate_tox.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@
6767
"gevent",
6868
"opentelemetry",
6969
"potel",
70-
# Integrations that can be migrated -- we should eventually remove all
71-
# of these from the IGNORE list
72-
"requests",
7370
}
7471

7572

scripts/populate_tox/tox.jinja

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,6 @@ envlist =
5454
# OpenTelemetry Experimental (POTel)
5555
{py3.8,py3.9,py3.10,py3.11,py3.12,py3.13}-potel
5656

57-
# Requests
58-
{py3.6,py3.8,py3.12,py3.13}-requests
59-
6057
# === Integrations - Auto-generated ===
6158
# These come from the populate_tox.py script. Eventually we should move all
6259
# integration tests there.
@@ -123,9 +120,6 @@ deps =
123120
# OpenTelemetry Experimental (POTel)
124121
potel: -e .[opentelemetry-experimental]
125122
126-
# Requests
127-
requests: requests>=2.0
128-
129123
# === Integrations - Auto-generated ===
130124
# These come from the populate_tox.py script. Eventually we should move all
131125
# integration tests there.

tox.ini

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# The file (and all resulting CI YAMLs) then need to be regenerated via
1111
# "scripts/generate-test-files.sh".
1212
#
13-
# Last generated: 2025-09-19T11:39:21.755227+00:00
13+
# Last generated: 2025-09-19T11:53:09.269997+00:00
1414

1515
[tox]
1616
requires =
@@ -54,9 +54,6 @@ envlist =
5454
# OpenTelemetry Experimental (POTel)
5555
{py3.8,py3.9,py3.10,py3.11,py3.12,py3.13}-potel
5656

57-
# Requests
58-
{py3.6,py3.8,py3.12,py3.13}-requests
59-
6057
# === Integrations - Auto-generated ===
6158
# These come from the populate_tox.py script. Eventually we should move all
6259
# integration tests there.
@@ -194,6 +191,9 @@ envlist =
194191
{py3.7,py3.10,py3.11}-httpx-v0.24.1
195192
{py3.9,py3.11,py3.12}-httpx-v0.28.1
196193

194+
{py3.6}-requests-v2.12.5
195+
{py3.9,py3.12,py3.13}-requests-v2.32.5
196+
197197

198198
# ~~~ Tasks ~~~
199199
{py3.7,py3.9,py3.10}-arq-v0.23
@@ -371,9 +371,6 @@ deps =
371371
# OpenTelemetry Experimental (POTel)
372372
potel: -e .[opentelemetry-experimental]
373373

374-
# Requests
375-
requests: requests>=2.0
376-
377374
# === Integrations - Auto-generated ===
378375
# These come from the populate_tox.py script. Eventually we should move all
379376
# integration tests there.
@@ -561,6 +558,9 @@ deps =
561558
httpx-v0.24.1: pytest-httpx==0.22.0
562559
httpx-v0.28.1: pytest-httpx==0.35.0
563560

561+
requests-v2.12.5: requests==2.12.5
562+
requests-v2.32.5: requests==2.32.5
563+
564564

565565
# ~~~ Tasks ~~~
566566
arq-v0.23: arq==0.23

0 commit comments

Comments
 (0)