Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rewrite API in NestJS #168

Draft
wants to merge 54 commits into
base: master
Choose a base branch
from
Draft

feat: Rewrite API in NestJS #168

wants to merge 54 commits into from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 8, 2024 •
edited
Loading

WIP

Rewriting the release registry API in Node/NestJS for dogfooding.

To Port:

  • GET /packages
  • GET /packages/:packageName/versions
  • GET /packages/:packageName/:version
  • GET /sdks
  • GET /sdks/:sdk_id/:version
  • GET /sdks/:sdk_id/versions
  • GET /apps
  • GET /apps/:app_id/:version
  • GET /marketing-slugs
  • GET /marketing-slugs/:slug
  • GET /aws-lambda-layers
  • GET /healthz
  • Setup CI (build, lint, test)
  • Add Sentry
  • caching
  • review error handling
  • review env variable controls
  • review CORS settings
  • review custom/additional http headers being set
  •  review query params
  • do we have custom alerts in sentry?
  • do we need ddog in the new version?
  • do we have custom alerts on ddog?

@Lms24 Lms24 self-assigned this Oct 9, 2024
Lms24 added 22 commits October 16, 2024 17:12
@Lms24
ensure that flask server doesn't crash locally when finding .DS-Store
387b3cf
@Lms24
add packages endpoint
ac8d2a2
@Lms24
add healthz controller
2795c77
@Lms24
add marketing-slug endpoint
2ab1ab0
@Lms24
cleanup
4d74a6e
@Lms24
add /apps/:appId/:version endpoint w/ extended functionality
58f76c4
@Lms24
improve tests
dadc043
@Lms24
add sdks endpoints
3e60611
@Lms24
add /aws-lambda-layers endpoint
fa176a3
@Lms24
add last /marketing-slugs/:slug endpoint
026b78e
@Lms24
consolidate packages and sdks service to registry service
9435503
@Lms24
consolidate marketing service
fcd043d
@Lms24
consolidate apps service
7d600de
@Lms24
move registry service to common
a742ff2
@Lms24
cleanup utils
40a92fb
@Lms24
cleanup, typing, linting
a5f0110
@Lms24
add ci for node api
e05bac5
@Lms24
update yarn lock
fda682c
@Lms24
add unit tests for package utils
ff63baf
@Lms24
adjust CI e2e tests
e03f8c1
@Lms24
adjust python api build/start scripts
cb161d8
@Lms24
working dir
aedcb62
Lms24 added 25 commits October 18, 2024 15:07
@Lms24
wip test against 20k URLs
d6c3f1d
@Lms24
add cors
c216cca
@Lms24
custom cache interceptor
2630082
@Lms24
20k url tests, pre-test refactor,
b1ea447
@Lms24
handle 404s, align headers
e337516
@Lms24
consistent headers in error responses, refactor normal e2e tests
d2a978a
@Lms24
run tests in ci again
9f6a114
@Lms24
build node API before running e2e tests in CI
9ced552
@Lms24
remove state in registry service, fix url test
e33aab9
@Lms24
align error handling, strict flag, ValueError
67fb56b
@Lms24
lint
8429639
@Lms24
restore json file
8cd0caa
@Lms24
dynamic port
a168742
@Lms24
volta, node 22
e06c27f
@Lms24
docker image for NestJS API
64f1859
@Lms24
logger, port
149eefc
@Lms24
adjust tests, port, use docker image in test
4b8f95f
@Lms24
test coudbuild of node api
81995c7
@Lms24
fix dockerignore and add install dev deps
70340c5
@Lms24
fix missing dev deps
9c82082
@Lms24
tmp skip source map upload for docker container for now
2d869a0
@Lms24
add auth token
06aeaf6
@Lms24
secretenv
fca50e8
@Lms24
maybe add version helps?
811efa7
@Lms24
swap secret versionName
bdd3e11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lms24