fix: Fixed Failed to find the closing bracket for custom gradle files (#1359)

Author: bitsandfoxes

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Fixes
 
+- Fixed an issue triggering an error `Failed to find the closing bracket` when using custom gradle files ([#1359](https://github.com/getsentry/sentry-unity/pull/1359))
 - Fixes Android native integration in the gradle output project for builds with Unity 2022.3 and newer ([#1354](https://github.com/getsentry/sentry-unity/pull/1354))
 
 ### Dependencies

src/Sentry.Unity.Editor/Android/GradleSetup.cs

@@ -134,11 +134,13 @@ private static int FindClosingBracket(string[] lines, int startIndex)
 
             for (var i = startIndex + 1; i < lines.Length; i++)
             {
-                if (lines[i].Contains("{"))
+                var line = lines[i];
+                if (line.Contains("{"))
                 {
                     openBrackets++;
                 }
-                else if (lines[i].Contains("}"))
+
+                if (line.Contains("}"))
                 {
                     if (openBrackets == 0)
                     {

test/Sentry.Unity.Editor.Tests/Android/GradleSetupTests.cs

@@ -120,6 +120,7 @@ public void ClearGradleProject_GradleFilesModified_RemovesModification(string un
         [TestCase("build.gradle_test_2.txt", "build.gradle_test_2_expected.txt")]
         [TestCase("build.gradle_test_3.txt", "build.gradle_test_3_expected.txt")]
         [TestCase("build.gradle_test_4.txt", "build.gradle_test_4_expected.txt")]
+        [TestCase("build.gradle_test_5.txt", "build.gradle_test_5_expected.txt")]
         public void InsertIntoScope_ResultMatchesExpected(string testCaseFileName, string testCaseExpectedFileName)
         {
             var assemblyPath = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);

test/Sentry.Unity.Editor.Tests/TestFiles/Android/build.gradle_test_5.txt

@@ -0,0 +1,31 @@
+allprojects {
+    buildscript {
+        repositories {**ARTIFACTORYREPOSITORY**
+            google()
+            jcenter()
+            maven { url 'https://plugins.gradle.org/m2/' }
+        }
+
+        dependencies {
+            // If you are changing the Android Gradle Plugin version, make sure it is compatible with the Gradle version preinstalled with Unity
+            // See which Gradle version is preinstalled with Unity here https://docs.unity3d.com/Manual/android-gradle-overview.html
+            // See official Gradle and Android Gradle Plugin compatibility table here https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
+            // To specify a custom Gradle version in Unity, go do "Preferences > External Tools", uncheck "Gradle Installed with Unity (recommended)" and specify a path to a custom Gradle version
+            classpath 'com.android.tools.build:gradle:4.0.0'
+            classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.12.6, 0.99.99]'
+            **BUILD_SCRIPT_DEPS**
+        }
+    }
+
+    repositories {**ARTIFACTORYREPOSITORY**
+        google()
+        jcenter()
+        flatDir {
+            dirs "${project(':unityLibrary').projectDir}/libs"
+        }
+    }
+}
+
+task clean(type: Delete) {
+    delete rootProject.buildDir
+}

test/Sentry.Unity.Editor.Tests/TestFiles/Android/build.gradle_test_5_expected.txt

@@ -0,0 +1,32 @@
+allprojects {
+    buildscript {
+        repositories {**ARTIFACTORYREPOSITORY**
+            google()
+            jcenter()
+            maven { url 'https://plugins.gradle.org/m2/' }
+        }
+
+        dependencies {
+            // If you are changing the Android Gradle Plugin version, make sure it is compatible with the Gradle version preinstalled with Unity
+            // See which Gradle version is preinstalled with Unity here https://docs.unity3d.com/Manual/android-gradle-overview.html
+            // See official Gradle and Android Gradle Plugin compatibility table here https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
+            // To specify a custom Gradle version in Unity, go do "Preferences > External Tools", uncheck "Gradle Installed with Unity (recommended)" and specify a path to a custom Gradle version
+            classpath 'com.android.tools.build:gradle:4.0.0'
+            classpath 'gradle.plugin.com.onesignal:onesignal-gradle-plugin:[0.12.6, 0.99.99]'
+            **BUILD_SCRIPT_DEPS**
+        }
+    }
+
+    repositories {**ARTIFACTORYREPOSITORY**
+        maven { url "${project(':unityLibrary').projectDir}/android-sdk-repository" }
+        google()
+        jcenter()
+        flatDir {
+            dirs "${project(':unityLibrary').projectDir}/libs"
+        }
+    }
+}
+
+task clean(type: Delete) {
+    delete rootProject.buildDir
+}