Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard for nextjs is using deprecated dependencies #658

Closed
vgrozdanic opened this issue Sep 3, 2024 · 5 comments · Fixed by #753
Closed

Wizard for nextjs is using deprecated dependencies #658

vgrozdanic opened this issue Sep 3, 2024 · 5 comments · Fixed by #753

Comments

@vgrozdanic
Copy link
Member

If you run a wizard for nextjs, there are 2 deprecation warnings:

Image

@Lms24
Copy link
Member

Lms24 commented Sep 6, 2024

Both of the glob and the inflight warnings would be resolved if we update glob. However, glob@9 requires Node 16 or higher which means we'd need to drop Node 14 support.

We already talked about dropping Node 14 support, ideally directly bumping to Node 18, to break away from EOL versions. I'm going to assign the "Breaking" Label here and put it to the new milestone issue. Cutting a major for the wizard is relatively cheap so we could do it. Just wanna make sure we're aligned within the team that we actually want to do this right now.

@Lms24 Lms24 added the Breaking label Sep 6, 2024
@Lms24 Lms24 modified the milestone: v4.0.0 Sep 6, 2024
@NickBrimmer
Copy link

Hi @Lms24 any updates on this? I'm seeing the same error when pairing the Wizard with @sentry/node installation with v20.18.0. Just wanting to check :)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 4, 2025
@Lms24
Copy link
Member

Lms24 commented Jan 7, 2025

Hey @NickBrimmer, no update at the moment. This didn't turn out to be of high priority for us. How is this issue impacting you? Just trying to re-assess prio

@Lms24
Copy link
Member

Lms24 commented Jan 7, 2025

So turns out we are in fact cutting a wizard major but I might have incorrectly stated that bumping glob requires node version support changes. Looks like [email protected] requires Node 14.17.0 or higher and our wizard requires Node 14.18.0

@NickBrimmer
Copy link

@Lms24 yes! Our team is implementing Sentry in for a tool that is being used for a few hundred clients. I'm glad to see this moved forward and was resolved! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants