-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: Add support for .NET/Unity SDK Crash detection #100091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #100091 +/- ##
===========================================
- Coverage 81.14% 81.14% -0.01%
===========================================
Files 8602 8602
Lines 381265 381275 +10
Branches 23924 23924
===========================================
+ Hits 309382 309387 +5
- Misses 71521 71526 +5
Partials 362 362 |
0cef0bb
to
571a7ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost, LGTM.
After we merge this, we still must create a dedicated project in Sentry for the .NET crashes similar to Cocoa https://sentry.sentry.io/issues/?project=4505469596663808&statsPeriod=14d.
Then we should enable it only for the sentry-sdk org and test if it actually works with an intentional SDK crash that the .NET SDK sends to https://sentry-sdks.sentry.io/issues/?project=5428537&statsPeriod=14d
After that, we can hand-pick a few organizations for an alpha run.
571a7ad
to
bd1c108
Compare
bd1c108
to
9855701
Compare
0e954e7
to
4ee86ca
Compare
4ee86ca
to
8309702
Compare
8309702
to
38c68ce
Compare
38c68ce
to
823faa5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
Note
Adds .NET/Unity SDK crash detection with new configuration options, fixtures, and tests.
SdkName.Dotnet
and build .NET/Unity crash-detection config (min SDK versions, system library patterns, SDK frame matching,report_fatal_errors=True
).issues.sdk_crash_detection.dotnet.project_id
,.organization_allowlist
,.sample_rate
..dotnet
and adjust expectations.Written by Cursor Bugbot for commit 9855701. This will update automatically on new commits. Configure here.