Skip to content

Conversation

mujacica
Copy link
Contributor

@mujacica mujacica commented Sep 23, 2025

  • Added support for .NET/Unity SDK Crash detection
  • Matching all Sentry.** modules
  • Extended current integration tests
  • Added new .NET/Unity integration tests

Note

Adds .NET/Unity SDK crash detection with new configuration options, fixtures, and tests.

  • SDK Crash Detection:
    • Add SdkName.Dotnet and build .NET/Unity crash-detection config (min SDK versions, system library patterns, SDK frame matching, report_fatal_errors=True).
    • Register options: issues.sdk_crash_detection.dotnet.project_id, .organization_allowlist, .sample_rate.
  • Tests:
    • Extend config tests to include .dotnet and adjust expectations.
    • Add .NET/Unity crash-detection tests validating frame stripping and detection logic.
  • Fixtures:
    • Add .NET/Unity crash event generators used by tests.

Written by Cursor Bugbot for commit 9855701. This will update automatically on new commits. Configure here.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 23, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #100091      +/-   ##
===========================================
- Coverage   81.14%    81.14%   -0.01%     
===========================================
  Files        8602      8602              
  Lines      381265    381275      +10     
  Branches    23924     23924              
===========================================
+ Hits       309382    309387       +5     
- Misses      71521     71526       +5     
  Partials      362       362              

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, LGTM.

After we merge this, we still must create a dedicated project in Sentry for the .NET crashes similar to Cocoa https://sentry.sentry.io/issues/?project=4505469596663808&statsPeriod=14d.

Then we should enable it only for the sentry-sdk org and test if it actually works with an intentional SDK crash that the .NET SDK sends to https://sentry-sdks.sentry.io/issues/?project=5428537&statsPeriod=14d

After that, we can hand-pick a few organizations for an alpha run.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mujacica mujacica merged commit 92f8005 into master Oct 2, 2025
65 checks passed
@mujacica mujacica deleted the feat/dotnet_sdk_crashes branch October 2, 2025 09:49
Copy link

sentry-io bot commented Oct 5, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants