Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): extend counter condition #73427

Merged
merged 5 commits into from
Jun 28, 2024
Merged

feat(metrics): extend counter condition #73427

merged 5 commits into from
Jun 28, 2024

Conversation

obostjancic
Copy link
Member

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 27, 2024
@obostjancic obostjancic marked this pull request as ready for review June 27, 2024 13:21
@obostjancic obostjancic requested a review from a team as a code owner June 27, 2024 13:21
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (c1a4aa0) to head (48f2320).
Report is 1 commits behind head on master.

❗ Current head 48f2320 differs from pull request most recent head 0c3a372

Please upload reports for the commit 0c3a372 to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #73427   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files        6634     6635    +1     
  Lines      296739   296663   -76     
  Branches    51108    51083   -25     
=======================================
- Hits       231491   231446   -45     
+ Misses      58861    58831   -30     
+ Partials     6387     6386    -1
Files Coverage Δ
.../sentry/snuba/metrics/span_attribute_extraction.py 100.00% <100.00%> (ø)

... and 72 files with indirect coverage changes

@obostjancic obostjancic enabled auto-merge (squash) June 28, 2024 06:37
@priscilawebdev priscilawebdev changed the title feat(metrics): extend counter condtion feat(metrics): extend counter condition Jun 28, 2024
shellmayr
shellmayr approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obostjancic obostjancic merged commit 54c9857 into master Jun 28, 2024
48 checks passed
@obostjancic obostjancic deleted the ogi/feat/span_attribute_extraction_counter branch June 28, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellmayr shellmayr shellmayr approved these changes

@vgrozdanic vgrozdanic vgrozdanic approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend metric extraction spec condition for counters
3 participants
@obostjancic @shellmayr @vgrozdanic