Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing vitals types when calculating overall performance score #77071

Open
bcoe opened this issue Sep 6, 2024 · 2 comments
Open

Handle missing vitals types when calculating overall performance score #77071

bcoe opened this issue Sep 6, 2024 · 2 comments
Assignees
@edwardgou-sentry
Labels
Product Area: Insights

Comments

@bcoe
Copy link
Member

bcoe commented Sep 6, 2024 •
edited
Loading

Safari does not populate LCP / INP / CLS, which results in an artificially lowered web vitals score.

Image

Solution Brainstorm

When calculating the overall score for each web vitals component we should only take into account scores that are truthy.
@getsantry
Copy link
Contributor

getsantry bot commented Sep 6, 2024

Routing to @getsentry/product-owners-insights for triage ⏲️

@bcoe bcoe added the Quick win! label Sep 6, 2024
@bcoe bcoe mentioned this issue Dec 12, 2024
Open
@edwardgou-sentry edwardgou-sentry self-assigned this Dec 18, 2024
@bcoe bcoe changed the title Differentiate between "no data" and 0, when calculating Web Vitals score Handle missing vitals types when calculating overall performance score Jan 2, 2025
@bcoe bcoe mentioned this issue Jan 2, 2025
Merged
@edwardgou-sentry
Copy link
Contributor

PRs:
#82649
#82762
#82686
#82750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwardgou-sentry edwardgou-sentry

Labels
Product Area: Insights
Projects
GitHub Issues with 👀 3
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @edwardgou-sentry