Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): handle missing vitals in tooltip weights #82809

Merged

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Jan 2, 2025

Updates webvital score breakdown timeseries tooltip to display proper weights when webvitals are missing
image

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 2, 2025
Base automatically changed from egou/feat/performance-score-functions-missing-vitals to master January 2, 2025 19:58
@edwardgou-sentry edwardgou-sentry requested a review from a team January 2, 2025 21:10
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review January 2, 2025 21:10
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner January 2, 2025 21:10
Copy link

codecov bot commented Jan 3, 2025

Bundle Report

Changes will increase total bundle size by 105.14kB (0.33%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.18MB 105.14kB (0.33%) ⬆️

@edwardgou-sentry edwardgou-sentry merged commit 7a624b6 into master Jan 3, 2025
42 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/handle-missing-vitals-in-tooltip-weights branch January 3, 2025 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants