Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.hostname #83695

Open
keradus opened this issue Jan 18, 2025 · 9 comments
Open

Add http.hostname #83695

keradus opened this issue Jan 18, 2025 · 9 comments

Comments

@keradus
Copy link
Contributor

keradus commented Jan 18, 2025

Problem Statement

we have http.url with full URL like https://github.com/getsentry/sentry/issues/new?template=feature.yml,
but I miss http.hostname with github.com only.

I want to be able to filter and present data by hostname for my project that is hosted under different domains. I can create filters like http.url is *github.com/* , but I cannot aggregate results.

Solution Brainstorm

add http.hostname field

Product Area

Issues

@getsantry
Copy link
Contributor

getsantry bot commented Jan 18, 2025

Assigning to @getsentry/support for routing ⏲️

@keradus
Copy link
Contributor Author

keradus commented Jan 18, 2025

cc @Angelodaniel

@getsantry
Copy link
Contributor

getsantry bot commented Jan 21, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 21, 2025
@malwilley
Copy link
Member

@keradus thanks for creating this issue! I have a couple followup questions to try to understand what you need:

I want to be able to filter and present data

What do you mean by "present data"? We do already display the hostname in the event details ("sentry.io" in this screenshot). Is there another place you would expect to see the hostname?

Image

I can create filters like http.url is github.com/ , but I cannot aggregate results.

Can you expand on what you mean by "cannot aggregate results" means in this context?

If we did add a hostname field to the event and added an http.hostname filter in search, how would that be different from using http.url is *github.com/* to filter results in the issue stream (besides being a bit more accurate)?

@keradus
Copy link
Contributor Author

keradus commented Jan 22, 2025

There is possibility to filter the data by regex, but not to represent them with aggregation.

Eg, you can create a dashboard with widget that is showing p90(LCP) aggregated by transaction. I need the same aggregated by http.hostname.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 22, 2025
@malwilley
Copy link
Member

@keradus okay I understand you! This makes sense as a feature request, so I'll add it to the backlog. This isn't one of our priorities at the moment though, so it may not see progress until we receive more feedback about it.

@keradus
Copy link
Contributor Author

keradus commented Jan 24, 2025

@malwilley thanks :thanks:

would you mind to define that threshold? some of requests that are top prio for my org like #55036 or #62608 got same and not prioritised for year+.
I understand the massive amount of request, what is the threshold (votes on github issue, $ in invoice we pay) to get prioritised ?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 24, 2025
@malwilley
Copy link
Member

@keradus I wish I could give you a rubric, but the answer is that it depends. The best metric is probably the number of GitHub votes/comments since our primary goal to is to develop features that impact a large number of users.

@keradus
Copy link
Contributor Author

keradus commented Jan 29, 2025

for anyone finding this request, here is the workaround I applied in my apps:

Sentry.init({
  initialScope: {
    tags: {
      hostname: location.hostname,
    }
  }
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants