Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(trace-explorer): Pin trace timestamps in the past #73485

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Zylphrex
Copy link
Member

When it's close to midnight, the timeout tests tends to fail because it actually finds the trace since it was not far enough in the past.

When it's close to midnight, the timeout tests tends to fail because it actually
finds the trace since it was not far enough in the past.
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (88ac464) to head (c15abd3).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #73485   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files        6634     6634           
  Lines      296733   296749   +16     
  Branches    51108    51110    +2     
=======================================
+ Hits       231490   231514   +24     
+ Misses      58855    58849    -6     
+ Partials     6388     6386    -2     

see 11 files with indirect coverage changes

@Zylphrex Zylphrex enabled auto-merge (squash) June 28, 2024 13:31
auto-merge was automatically disabled June 28, 2024 17:43

Pull Request is not mergeable

@Zylphrex Zylphrex merged commit 3d4631e into master Jun 28, 2024
47 checks passed
@Zylphrex Zylphrex deleted the txiao/tests/pin-trace-timestamps-in-the-past branch June 28, 2024 19:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants