Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages: change metainfo, .desktop and image file symlinks to install commands for appstream builder #4350

Open
TraceyC77 opened this issue Nov 13, 2024 · 1 comment
Labels
Type: Chore Not a feature or a bug

Comments

@TraceyC77
Copy link
Contributor

appstream builder cannot handle symlinks, use install instead in package.yml for

  • .desktop files
  • image files like .png
  • appdata.xml files

Update all packages using symlinks to use install instead for these

Note:
Valid paths for appstream metainfo are:
/usr/share/metainfo/org.some.package.xml
/usr/share/appdata/org.some.package.xml <- legacy, discouraged.

An example of a package that used symlinks is yubico-authenticator. This PR was made to update it (and add an appdata file)

Old:

    ln -s $YUBIOATH_DIR/linux_support/com.yubico.authenticator.desktop $installdir/usr/share/applications/com.yubico.authenticator.desktop
    ln -s $YUBIOATH_DIR/linux_support/com.yubico.yubioath.png $installdir/usr/share/pixmaps/com.yubico.yubioath.png

New:

    install -Dm00644 $installdir/$YUBIOATH_DIR/linux_support/com.yubico.authenticator.desktop $installdir/usr/share/applications/com.yubico.yubioath.desktop
    install -Dm00644 $installdir/$YUBIOATH_DIR/linux_support/com.yubico.yubioath.png $installdir/usr/share/icons/hicolor/128x128/apps/com.yubico.yubioath.png
    install -Dm00644 $pkgfiles/com.yubico.yubioath.appdata.xml -t $installdir/usr/share/metainfo/
@github-project-automation github-project-automation bot moved this to Triage in Solus Nov 13, 2024
@TraceyC77 TraceyC77 added the Type: Chore Not a feature or a bug label Nov 13, 2024
@TraceyC77 TraceyC77 changed the title appstream: change metainfo, .desktop and image file symlinks to install commands packages: change metainfo, .desktop and image file symlinks to install commands for appstream builder Nov 13, 2024
@TraceyC77
Copy link
Contributor Author

@TraceyC77 TraceyC77 moved this from Triage to Ready in Solus Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Chore Not a feature or a bug
Projects
Status: Ready
Development

No branches or pull requests

1 participant