Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github action doesn't detect when a test suite is failing #890

Closed
jaesivsm opened this issue May 5, 2022 · 0 comments · Fixed by #891
Closed

Github action doesn't detect when a test suite is failing #890

jaesivsm opened this issue May 5, 2022 · 0 comments · Fixed by #891
Labels
maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers

Comments

@jaesivsm
Copy link
Contributor

jaesivsm commented May 5, 2022

Noticed that while developing a small patch in #889
The first commit shows a green mark but the test actually fails badly because of a typo of mine.
It shouldn't have and a warning should have been issued.
@jaesivsm jaesivsm mentioned this issue May 5, 2022
Merged
jaesivsm added a commit to jaesivsm/gtg that referenced this issue May 5, 2022
@jaesivsm
Yay, they failed, and now, we fix
41ed755 
closes getting-things-gnome#890
diegogangl pushed a commit that referenced this issue May 13, 2022
@jaesivsm @diegogangl
Yay, they failed, and now, we fix
5f72c8a 
closes #890
@nekohayo nekohayo added the maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Github Actions not failing on broken test suit jaesivsm/gtg
2 participants
@nekohayo @jaesivsm