Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BoundsCheckPolicies.image_store #5882

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Remove BoundsCheckPolicies.image_store #5882

merged 1 commit into from
Jul 26, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jun 26, 2024

Follow-up to gfx-rs/naga#2265 & #3975.
Spec PR: gpuweb/gpuweb#4194.
Resolves #5878.

@teoxoy teoxoy requested review from a team as code owners June 26, 2024 08:02
jimblandy
jimblandy approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I love deleting code without removing features.

naga/src/proc/index.rs Outdated Show resolved Hide resolved
@jimblandy jimblandy enabled auto-merge (rebase) July 26, 2024 17:32
@jimblandy jimblandy merged commit ccd6d2c into gfx-rs:trunk Jul 26, 2024
25 checks passed
@teoxoy teoxoy deleted the remove-image_store branch July 26, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Naga worries too much about storage texture writes
2 participants
@teoxoy @jimblandy