Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naga shouldn't evaluate overrides unless they're used by the entry point #5885

Open
jimblandy opened this issue Jun 26, 2024 · 0 comments
Open
Labels
area: naga back-end Outputs of naga shader conversion naga Shader Translator type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

When generating code for a naga::Module, Naga currently evaluates every override-expression it can, regardless of whether that expression is statically used by the entry point(s) for which we are generating code. The WGSL committee's recent discussions clarified that errors should only be reported from override-expressions that are actually statically used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: naga back-end Outputs of naga shader conversion naga Shader Translator type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant