-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
area: robustnessMinimizing the impact when things go wrongMinimizing the impact when things go wrongkind: refactorMaking existing function faster or nicerMaking existing function faster or nicertype: enhancementNew feature or requestNew feature or request
Description
A couple possible simplifications that came up in working on #8203 and discussion in today's maintainers meeting:
- Naga has an enum
SubgroupOperationSet
that finely classifies the supported subgroup operations. It is not clear that this is necessary and non-standard configurations are not well tested. Consider removing it. - There is logic to set
Capabilities::SUBGROUP
wheneverFeatures::SUBGROUP_VERTEX
is set.wgpu/wgpu-core/src/device/mod.rs
Line 495 in 1791064
features.intersects(wgt::Features::SUBGROUP | wgt::Features::SUBGROUP_VERTEX), Capabilities::SUBGROUP
is available wheneverFeature::SUBGROUP_VERTEX
is, it seems simpler not to do this kind of mapping of feature enables behind the scenes due to the risk of confusion. It would be better if theCapabilities
andFeatures
aligned exactly.
Metadata
Metadata
Assignees
Labels
area: robustnessMinimizing the impact when things go wrongMinimizing the impact when things go wrongkind: refactorMaking existing function faster or nicerMaking existing function faster or nicertype: enhancementNew feature or requestNew feature or request