Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a recent commit, the shortcut labels will remain on screen after pressing s as a label #102

Closed
againxx opened this issue Dec 4, 2021 · 7 comments

Comments

@againxx
Copy link

againxx commented Dec 4, 2021

After a recent commit 6f3f20a, when the s key appeared in the label lists, and have been pressed for a jump. New labels will appear and remain forever.

In the following example, I first pressed us and the s was shown as a normal label.
Screenshot from 2021-12-04 17-53-15

After I pressed s to jump to the destination, a set of new labels appear and won't disappear before pressing any key.

Screenshot from 2021-12-04 17-53-28

@ggandor
Copy link
Owner

ggandor commented Dec 4, 2021

This is intended. You can walk through the matches by pressing <Plug>Lightspeed_s repeatedly, as with f or t. If you'd change the first label on the list to something else, the plugin would exit as usual, but it's logical to use the key mapped to <Plug>Lightspeed_s as the first label too, since they are functional equivalents of each other. NB: Those are not "new" labels technically, but the old ones highlighted as "shortcuts" from then on.

The labels remain there forever, because 02c3138 disabled the default auto-exit for s/x, but you can still set the timeout manually, if you like the feature.

@ggandor ggandor closed this as completed Dec 4, 2021
@mikehaertl
Copy link

@ggandor I'm suffering from this, too. To be honest I don't get the idea here. If we entered the label for the first match, we already made a choice. Why should we want to walk through other matches? Maybe I also misunderstand completely. This plugin started to do a lot of magic things that unfortunately start to get in the way now.

What I want to achieve is basically disable all this auto-magic as it's too much for my brain. It breaks my flow when I have to consider that behavior after jumping to the first is different than for other matches.

I would prefer to simply have labels for everything (including first match). As the config option for this was removed, I tried with setting safe_labels = nil. But then I suffer from the problem described here.

I also used the timeout feature (which I actually suggested some time ago #62) but I'm not happy with it either. Things often either go to fast (especially if I have groups - my brain needs time to get what's going in) or too slow.

@mikehaertl
Copy link

Ok, I figured it out. I thought you talk about safe_labels above - but you meant labels. So not listing s in labels really seems to do the trick.

@ggandor
Copy link
Owner

ggandor commented Feb 3, 2022

@mikehaertl You are right, I've already made a note to myself. Generally, we should only allow this super-clever instant-repeat mode (where the labels also remain available) when there are no unsafe labels, i.e. if someone always uses auto-jump. I will fix this ASAP.

@ggandor
Copy link
Owner

ggandor commented Feb 3, 2022

To be honest I don't get the idea here. If we entered the label for the first match, we already made a choice. Why should we want to walk through other matches?

This is just an alternative, in some cases, or for some people, it might be more comfortable (less mental energy) to simply type ;;; like a machine gun, and jump from match to match, if the target is, say, the 2nd-5th match - that is, to use s like f/t. But, similar to f/t, we also allow s itself to trigger repeat, instead of a separate, dedicated repeat key (;). This is nothing new in itself, Sneak works the same way, which in turn took the idea from clever-f, and extended it to s/S.

@mikehaertl
Copy link

I see, thanks for the clarification.

Sidenote: It would be great to see more terminal recordings (in the README or on a dedicated page) to show more/all features. It's much easier to learn if you see things in action than to wade through a long and complex description. (If only there was a pause key for animated GIFs, though. Did you consider something like asciinema? I also found a nice roundup of terminal recording tools here: https://linoxide.com/linux-terminal-recording-tools/. But for a start even more GIFs would be fine.)

@ggandor
Copy link
Owner

ggandor commented Feb 3, 2022

Yes, absolutely. See #75. Any further ideas are welcome.

@ggandor ggandor changed the title After a recent commit, the shortcut labels will remained after pressing s as a label After a recent commit, the shortcut labels will remain on screen after pressing s as a label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants