-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open_in_youtube is outdated #112
Comments
Yeah its probably outdated and I wanted to rework the implementation of the yt search but it would be great if you could do it 👍 |
Yeah, i had a look on the youtube api, we could use that. But its another api-key you need to have. The "problem" with the current solution (using requests.get) is, that the yt-searchresult page is build with lots of javascript, meaning you wont get the full page without something like selenium. It works, but obviously it will break again as soon as yt will change a single character in there :/ How are your thought on dependencys? Also we could just implement both ways: |
Sounds solid but as you mentioned it can break when YouTube changes things. When I think about it why don't we use ytdl? |
As i said, it depends if we want to make a yt-api key mandatory. Also, did someone consider music.youtube.com? However, lots of possibilities :D |
I really think the simplest way is just using pywhatkit:
|
Hi,
it seems like the 'open_in_youtube'-Skill is not working (at least for me). So 'jarvis play mozart' will always tell you 'I can't find what do you want in Youtube..'.
I guess yt reworked their searchpage and the old implementation (2 years ago), using bs4 and trying to find the top video via
class': 'yt-uix-tile-link'
is not working anymore.I'm already working on a fix for that. However, i wanted to create this issue first, just to make sure its not a bug/problem only on my side.
So it would be nice if someone can actually confirm that 'jarvis play xyz' fails with 'I can't find what do you want in Youtube..'.
If so, i'll publish my fix and create a pullrequest.
Also, it's the first time for me, contributing to another ones project and providing pull requests. So if i miss anything or could improve something, please just let me know.
The text was updated successfully, but these errors were encountered: