Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-client should look for 'hdl-prj.json' through the path of a file #5

Open
eine opened this issue Jun 17, 2019 · 2 comments
Open

Comments

@eine
Copy link
Contributor

eine commented Jun 17, 2019

The extension looks for 'hdl-prj.json' in the root of the workspace only. However, it is reasonable for users to have multiple projects in different subdirs of the workspace. I think that it would be useful if the extension looked for the JSON file bottom-up (from the location of the file to the workspace).

@tgingold
Copy link
Member

I am not sure about that.

vs-code is really directory based, but some of the extensions work with a project file. I think C# needs a project file. I'd like to understand how they handle projects.

@eine
Copy link
Contributor Author

eine commented Jun 18, 2019

There is the concept of multi-root workspaces: https://code.visualstudio.com/docs/editor/multi-root-workspaces For example, in VUnit, using multi-root workspaces would require defining each example as a folder in the workspace, and another one for VUnit itself. Otherwise, all the sources are considered to belong to the same project.

In GHDL, the following ghdl.code-workspace can be used, provided that the three repos are cloned in the same parent dir:

{
	"folders": [
		{
			"path": "ghdl"
		},
		{
			"path": "ghdl-docker"
		},
		{
			"path": "ghdl-ls"
		}
	]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants