Redundant WorkDirectory ?

[gothicx]

This module defines two times the WorkDirectory with different default paths. Do we need the spool_dir options? we couldn't just use the rsyslog::work_directory option only and use the path /var/lib/rsyslog ?

[ghoneycutt]

It seems that work_directory and spool_dir are both supposed to do the same thing. work_directory does not do anything in the manifests and only comes into play if mod_imjournal is true.

spool_dir and its related config options spool_dir_owner, spool_dir_group and spool_dir_mode should be renamed to use work_directory, as that name matches up with the rsyslog configuration option.

[ghoneycutt]

CC: Adding major contributors @anders-larsson @Phil-Friderici

Anything else you all would like to change that could potentially break backward compatibility? If so, I would like to do that at the same time as this fix.

[Phil-Friderici]

@ghoneycutt beside a 'zünftig' refactor I have nothing on my wish list. But as always time is the limiting factor.

[anders-larsson]

I cannot think of anything right now.

[Phil-Friderici]

@ghoneycutt remove the sysklogd dependency by integrating it into rsyslog or make it mandatory on RH5 only.