Throwing an exception in codegen for empty enums #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Caliban currently generates code for empty enums.
* The generated code, however, fails to compile.
* Although Caliban should successfully parse an empty enum, it should _not_
generate code for one at all.
* In this case, I throw an exception when code generation is attempted for
an empty enum.
|
Ideally I'd like to add some tests for this behaviour. I don't see any code that executes failure cases in |
Yep that's okay! Note that you need to use |
|
Closing old PRs, but feel free to reopen it targeting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate code for one at all.
an empty enum.
See #1253 for the full discussion on this.
Also closes #1253