Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv file format support #99

Open
darlaam opened this issue Jul 25, 2024 · 1 comment
Open

dotenv file format support #99

darlaam opened this issue Jul 25, 2024 · 1 comment

Comments

@darlaam
Copy link

darlaam commented Jul 25, 2024

Great job for rops.
I've an use-case where I'd to use a dotenv file format, but it's not (yet) implemented in rops. Do you have any plan for it ?

@gibbz00
Copy link
Owner

gibbz00 commented Jul 28, 2024

I don't have an immediate plan for it, but I would not hold anyone against creating a PR 😊

One thing I do want to explore though, is direct implementation of Serialize/Deserialize on the RopsTree<DecryptedMap>/RopsTree<EncryptedMap<C>> rather than writing format specific implementations on FileFormatValueAdapter/FileFormatKeyAdapter. This could possibly make the addition of new file formats pretty trivial.

Should note that I don't think the popular envy supports nested structs, and serde-env does not seem to support a EnvValue similar to serde_json::Value. So Serialize/Deserialize implementations on the respective structs be required after all.

A serde_value approach may also be worth looking into.

@gibbz00 gibbz00 changed the title Any plan to support dotenv format ? dotenv fileformat support Jul 28, 2024
@gibbz00 gibbz00 changed the title dotenv fileformat support dotenv file format support Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants