Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax highlighting in VSCode requires space between elm and open brace #50

Open
jwoLondon opened this issue Sep 3, 2020 · 3 comments

Comments

@jwoLondon
Copy link
Member

Code block headers expressed as elm{l} and elm {l} (note the space in the second example) both work. In Atom syntax highlighting is applied to the block of code correctly, but in VSCode with the elm-tooling plugin (the one we recommend for litvis), only the second case with a space generates correct syntax colouring.

I assume the problem is with the elm-tooling plugin for VSCode, but could apply a Prettier type auto formatting to ensure a single space between the elm and { ?

@kachkaev
Copy link
Member

kachkaev commented Sep 5, 2020

Created remarkjs/remark#528 and prettier/prettier#9155 to see if we can fix this on the formatting front.

@kachkaev
Copy link
Member

kachkaev commented Oct 4, 2020

Hi Jo! WDYT of stopping the support of non-whitespace characters as the delimiter in litivs? See remarkjs/remark#528 (comment).

Doing so will include the removal of my hack in Prettier prettier/prettier#4783 as well as changing how mume separates the args from the language 'word'. This will make things in sync with how VSCode highlights the syntax.

I think that we initially got confused by what Atom was doing. If it only looked for spaces and tabs as word separators, we would do too. At the moment, it seems like we've ended up on a small island of not following the markdown specs.

@jwoLondon
Copy link
Member Author

Yes, that makes sense, for the reasons discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants