Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main branch? Common dir layout? #3

Open
snomos opened this issue Nov 1, 2022 · 0 comments
Open

Use main branch? Common dir layout? #3

snomos opened this issue Nov 1, 2022 · 0 comments
Assignees

Comments

@snomos
Copy link
Member

snomos commented Nov 1, 2022

We have switched branches/branch names from master to main. I have merged your commit 83a5a2f with main. It would be nice if you could continue your work in the main branch 馃檪

To avoid heavy branch merges with high risk of conflicts in the future, I have locked (but not removed) the master branch. I hope this is ok.

Also, I notice you have a different source dir structure. To reap the most of the GiellaLT infrastructure it would be good to follow the general layout. For now I will move your srcV2 dir to within src/fst/, but with a symlink in the old location, so that your build will work as well.

Hm, come to think of it: your Makefile will block the creation of the GiellaLT Makefile, so the GiellaLT build will most likely fail. We need to figure out a way to solve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants