[Bug] Crash when opening book with empty chapters/sections

[ElectroBot]

The book below (with and without the empty sections) crashes the game. I was trying to find out how to have empty pages (realized later the sections are the pages).

<book title="Test book" cover="gbook:topsecret" fontSize="0.6" home="1:2"> <chapter> <section> </section> </chapter> </book>

Minecraft: 1.12.2
Forge: 14.23.5.2772
Guidebook: 1.12.2-2.8.3

Crash report: https://paste.dimdev.org/apusogiwor.rb

[QbDesu]

Yes this is an issue with empty chapters.

Guidebook/src/main/java/gigaherz/guidebook/guidebook/client/BookRendering.java

Line 475 in cea8c04

final VisualPage pgLeft = ch.pages.get(currentPair * 2);

The line above throws an IndexOutOfBoundsException.
A possible way to fix this would be applying the same checks that are applied to the right-hand page for the left-hand page as well. Alternatively empty chapters could be removed and maybe a book without a chapter would not be able to open or automatically appear blank.

[ElectroBot]

There are uses for empty pages though (aesthetic). Not sure if applying the checks or maybe adding a tag for an blank page would doable.

[gigaherz]

It's definitely a bug that needs fixing. Just gotta get around to it.

…

On Sat, 17 Nov 2018, 18:43 ElectroBot ***@***.*** wrote: There are uses for empty pages though (aesthetic). Not sure if applying the checks or maybe adding a tag for an blank page would doable. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#80 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAp3Gy-176uNHfau_Ova8L2WvDXuZaC7ks5uwEq6gaJpZM4YLSIq> .