-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Improvements #1504
Comments
1 and 3 will be implemented in the version |
@gildas-lormeau Please, When the update is released post a comment, so I could test it |
@StoopidoMan I've just uploaded on the stores the version |
For the record. Here is an example in the zip file of saved page with the infobar and its flashing icon. |
Only 4 is not implemented (yet). Making the version available as a variable requires some work because this code resides in the project |
sorry for the late response, I am in pain, physically. 1- The info bar: I am not sure what to suggest because this kind of things requires a brainstorming session in a meeting. I will try to share some points:
3- in the infobar I wanted to add Notes, saved date, and page title, I used the code below:
I suggested adding a multi line field because a single short field limits me from adding comments/notes comfortably so a bigger field or expandable field would be great specially if adding new line by pressing enter is supported.
I am sorry. |
@StoopidoMan Just a quick answer about the infobar, I'll come back to the other points later. I've added an option Here's an example in the ZIP file: Example Domain (30_07_2024 00_18_13).html.zip By the way, I haven't had time to test this yet, but the "delay" values passed as |
I agree that is a very good idea, however I like to suggest some improvement: 1- With the original model, if you click somewhere random the infobar collapse to an infobar-icon, check the video below: Firefox.Cuwpmakzsq.mp4but this didn't happen with the html file sample you provided. I think the old way will satisfy the need of more users and it is more user friendly. Additionally, if possible to collapse the infobar to inforbar-icon on scroll would also be a good feature, so if the user click somewhere on the page or scroll the infobar would collapse to the infobar-icon. 2- I think adding a "minimize" or "collapse infobar" button similar to how the minimize button works in Windows OS will help the user experience. 3- Changing the color of open source URL icon to a standard blue links color, and would change to a standard purple link when already visited, would be more noticeable as a button than just being gray: did a quick google search and found these two links for your convenience: An answer from stackoverflow.com 4- Moving the close, minimize, and open source URL buttons to the top part of the infobar: The reason for this suggestion is because I have a disability and for me when UI elements are not separated with UI dividers it somehow gets mixed up... It is hard to explain. Here is a rough example of what I mean (I am no graphic designer) 5- You could aslo add a 5 second timer and after that the infobar would collapse to infobar-icon, when opening the html file . 6- adding "Saved with SingleFile Vx.x" as a title of the infobar and when clicked on "Saved with SingleFile Vx.x" it would take you to a simple page with links to all major browsers extension market place and Github. 7- about Thank you for your hard work. and sorry if I was stoopid |
1- by default the infobar icon, would be flashing for 3-5 seconds (switch between yellow and gray) and settles on Gray at the end to attract user attention.
Reason for the suggestion:
When a file is shared, or when the user open the file in far future they will notice the infobar icon. I have a concern that I would forget about it and it is hard to notice. Maybe it is just me.
However, I would advise against this IF you think the code which result in flashing the infobar icon might break in future browsers when the file is opened. The idea of Singlefile is to save an archival version of the file for digital preservation, in my humble STOOPID opinion, thus avoiding things that might cause issues.
unrelated suggestions:
2- The time/date variables are too limited, not fully customizable, if it is customizable then I am too stoopid to figure it out:
hh:mmttd/M/yyyy
With that format the leading zero for month and day is removed and can be added by just adding another
m/d
. Additionally, thett
adds the PM/AM and I can control which character I can put between each variable like/ . \ -_ ; :
and to have the hours in 24H format I you can capitalize itHH
Windows/Autohotkey style is easier for not so technical users like me.
3- in the infobar I wanted to add Notes, saved date, and page title, I used the code below:
Page title: {page-title} \n Saved on: Wed Jul 10 2024 01:14:48 GMT+0200 (Central European Summer Time) \n \n Notes:
but it is hard to add notes, so I suggest the window for
infobar contect
would be multiple lines and accept new line by pressing enter to add notes in several lines.4- Addition of a variable to add a link to SingleFile project in infobar and the version it was saved with.
The Reason for this suggestion: It will help promote SingleFile, and also, have a record of which version of SingleFile was used to save the webpage.
5- Lastly, if
Template of the infobar content
left empty, it will save in this formatWed Jul 10 2024 01:14:48 GMT+0200 (Central European Summer Time)
I tried my best, but I couldn't replicate it, I wanted to add,
GMT+0200 (Central European Summer Time)
And
Wed
Jul
but I couldn't find any variable, I would appreciate it if you would tell me how to add the date in this format:
01:14:48AM 10/07/2024 GMT+0200 (Central European Summer Time)
and in this formatyyyy.mm.dd.hh.mmtt
Thank you for your hard work.
Originally posted by @StoopidoMan in #1469 (comment)
The text was updated successfully, but these errors were encountered: