Skip to content

Commit b3c7788

Browse files
authored
chore: logging full path including query params (#61)
1 parent 4121d9d commit b3c7788

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

logger.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func SetLogger(opts ...Option) gin.HandlerFunc {
107107
l = l.With().
108108
Int("status", c.Writer.Status()).
109109
Str("method", c.Request.Method).
110-
Str("path", c.Request.URL.Path).
110+
Str("path", path).
111111
Str("ip", c.ClientIP()).
112112
Dur("latency", latency).
113113
Str("user_agent", c.Request.UserAgent()).Logger()

logger_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -50,20 +50,23 @@ func TestLogger(t *testing.T) {
5050
assert.Contains(t, buffer.String(), "200")
5151
assert.Contains(t, buffer.String(), "GET")
5252
assert.Contains(t, buffer.String(), "/example")
53+
assert.Contains(t, buffer.String(), "path=/example?a=100")
5354

5455
buffer.Reset()
5556
performRequest(r, "POST", "/example?a=100")
5657
assert.Contains(t, buffer.String(), "400")
5758
assert.Contains(t, buffer.String(), "POST")
5859
assert.Contains(t, buffer.String(), "/example")
5960
assert.Contains(t, buffer.String(), "WRN")
61+
assert.Contains(t, buffer.String(), "path=/example?a=100")
6062

6163
buffer.Reset()
6264
performRequest(r, "PUT", "/example?a=100")
6365
assert.Contains(t, buffer.String(), "502")
6466
assert.Contains(t, buffer.String(), "PUT")
6567
assert.Contains(t, buffer.String(), "/example")
6668
assert.Contains(t, buffer.String(), "ERR")
69+
assert.Contains(t, buffer.String(), "path=/example?a=100")
6770
}
6871

6972
func TestLoggerWithLogger(t *testing.T) {

0 commit comments

Comments
 (0)