Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for MKL 2025 #1717

Open
rscohn2 opened this issue Oct 29, 2024 · 1 comment · May be fixed by #1718
Open

Update for MKL 2025 #1717

rscohn2 opened this issue Oct 29, 2024 · 1 comment · May be fixed by #1718
Labels
is:bug Something looks wrong.

Comments

@rscohn2
Copy link

rscohn2 commented Oct 29, 2024

MKL single argument release_matrix_handle was deprecated in 2023 and removed in 2025

ginkgo/dpcpp/matrix/csr_kernels.dp.cpp

Line 1420 in 568a759

oneapi::mkl::sparse::release_matrix_handle(&mat_handle);

https://www.intel.com/content/www/us/en/docs/onemkl/developer-reference-dpcpp/2025-0/oneapi-mkl-sparse-release-matrix-handle.html

We are trying to release oneapi 2025 on Spack, but e4s build is failing:
spack/spack#47264
with this error

/tmp/root/spack-stage/spack-stage-ginkgo-1.8.0-bqbygy3vpm73xu5bswwd4eo7ekitjsrm/spack-src/dpcpp/matrix/csr_kernels.dp.cpp:1424:63: error: too few arguments to function call, expected at least 2, have 1
 1424 |         oneapi::mkl::sparse::release_matrix_handle(&mat_handle);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~            ^
/home/software/spack/[padded-to-256-chars]/linux-ubuntu22.04-x86_64_v3/oneapi-2024.2.1/intel-oneapi-mkl-2025.0.0-trzhgb6lg67dxvpj47qoycibohcjnzus/mkl/latest/include/oneapi/mkl/spblas/sparse_structures.hpp:41:1: note: 'release_matrix_handle' declared here
   41 | release_matrix_handle(sycl::queue &queue,
      | ^                     ~~~~~~~~~~~~~~~~~~~
   42 |                       matrix_handle_t *p_spMat,
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~
   43 |                       const std::vector<sycl::event> &dependencies = {});

There might be more deprecation/removal issues. Would it be possible to update Ginkgo?
@rscohn2 rscohn2 mentioned this issue Oct 29, 2024
Merged
@MarcelKoch MarcelKoch linked a pull request Oct 29, 2024 that will close this issue
Open
2 tasks
@MarcelKoch
Copy link
Member

This seems easy to fix on our side. I created a PR for that, but we have to wait a bit until our intel CI is running again.

@MarcelKoch MarcelKoch added the is:bug Something looks wrong. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:bug Something looks wrong.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated oneMKL call ginkgo-project/ginkgo
2 participants
@rscohn2 @MarcelKoch