Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose build command line in README.md is incorrect. #27

Closed
stevenjswanson opened this issue Dec 28, 2022 · 2 comments
Closed

Comments

@stevenjswanson
Copy link

You have

SLURM_TAG=slurm-19-05-2-1 IMAGE_TAG=19.05.2 docker-compose build

But I think you need to use --build-arg to set those variable so they are used by Dockerfile

@giovtorres
Copy link
Owner

You would use --build-arg when using the docker CLI. However, when using docker-compose, prefixing the command with these environment variables passes it into the docker-compose.yml file here, for example. The docker-compose.yml file has defaults which you can override at runtime.

@giovtorres
Copy link
Owner

The Dockerfile can interpolate variables from the environment.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants