You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The TMS extension on my ChromeTab does not react to typing input into a form the way it is intended to AFAICT, that is like in this screenshot of a fixed version of @dvalter's version for firefox:
1- the event variable isn't defined; easily fixed by renaming the e argument to event
2- the keyCode property has been deprecated for quite some time
3- the code only checks for inputs in the range '0' to 'Z', basically the 10 digits and uppercase Roman letters.
The latter 2 can be fixed by changing the range check to
The Firefox version is based on an older fork of the original TGS and also has an issue-by-design where emptying the form doesn't unpause the extension. I haven't yet figured that one out and thus also not if that aspect has been fixed in this TMS version.
The text was updated successfully, but these errors were encountered:
🇮🇹 Grazie per aver aperto la segnalazione. Ti informo, però, che il progetto è in fase di chiusura. Vedi #196.
🇬🇧 Thank you for opening the issue. Please be advised, however, that the project will soon be closed due to Chrome V3 manifest and new policies. Please take a look here: #196.
The TMS extension on my ChromeTab does not react to typing input into a form the way it is intended to AFAICT, that is like in this screenshot of a fixed version of @dvalter's version for firefox:
I see 2 reasons and a more general issue:
MarvellousSuspender/src/js/contentscript.js
Line 19 in 683509a
1- the
event
variable isn't defined; easily fixed by renaming thee
argument toevent
2- the
keyCode
property has been deprecated for quite some time3- the code only checks for inputs in the range '0' to 'Z', basically the 10 digits and uppercase Roman letters.
The latter 2 can be fixed by changing the range check to
See https://github.com/dvalter/ff-thegreatsuspender/pull/7/files
The Firefox version is based on an older fork of the original TGS and also has an issue-by-design where emptying the form doesn't unpause the extension. I haven't yet figured that one out and thus also not if that aspect has been fixed in this TMS version.
The text was updated successfully, but these errors were encountered: