Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause for forms with input most likely broken. #242

Open
RJVB opened this issue Nov 13, 2024 · 1 comment
Open

Pause for forms with input most likely broken. #242

RJVB opened this issue Nov 13, 2024 · 1 comment
Assignees

Comments

@RJVB
Copy link

RJVB commented Nov 13, 2024

The TMS extension on my ChromeTab does not react to typing input into a form the way it is intended to AFAICT, that is like in this screenshot of a fixed version of @dvalter's version for firefox:
image

I see 2 reasons and a more general issue:

if (event.keyCode >= 48 && event.keyCode <= 90 && event.target.tagName) {

1- the event variable isn't defined; easily fixed by renaming the e argument to event
2- the keyCode property has been deprecated for quite some time
3- the code only checks for inputs in the range '0' to 'Z', basically the 10 digits and uppercase Roman letters.

The latter 2 can be fixed by changing the range check to

event.key >= "0" && event.key <= "z"

See https://github.com/dvalter/ff-thegreatsuspender/pull/7/files

The Firefox version is based on an older fork of the original TGS and also has an issue-by-design where emptying the form doesn't unpause the extension. I haven't yet figured that one out and thus also not if that aspect has been fixed in this TMS version.

Copy link

🇮🇹 Grazie per aver aperto la segnalazione. Ti informo, però, che il progetto è in fase di chiusura. Vedi #196.

🇬🇧 Thank you for opening the issue. Please be advised, however, that the project will soon be closed due to Chrome V3 manifest and new policies. Please take a look here: #196.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants