fix(web): check for logged in user by USER_SERVICE, not token

Update project reviews and rules pages to check for logged-in user by USER_SERVICE and redirect home if not logged in, rather than by auth token.

Also add refreshUser method to userService.ts to refresh user state and handle errors.

Author: estib-vega

apps/web/src/lib/user/userService.ts

@@ -73,6 +73,16 @@ export class UserService {
 		return user;
 	}
 
+	async refreshUser() {
+		try {
+			const user = await this.fetchUser();
+			this.user.set(user);
+			this.error.set(undefined);
+		} catch (error) {
+			this.error.set(error);
+		}
+	}
+
 	clearUser() {
 		this.user.set(undefined);
 	}

apps/web/src/routes/(app)/[ownerSlug]/[projectSlug]/reviews/+page.svelte

@@ -1,9 +1,9 @@
 <script lang="ts">
 	import { goto } from '$app/navigation';
-	import { AUTH_SERVICE } from '$lib/auth/authService.svelte';
 	import BranchIndexCard from '$lib/components/branches/BranchIndexCard.svelte';
 	import DashboardLayout from '$lib/components/dashboard/DashboardLayout.svelte';
 	import Table from '$lib/components/table/Table.svelte';
+	import { USER_SERVICE } from '$lib/user/userService';
 	import { inject } from '@gitbutler/core/context';
 	import { getBranchReviewsForRepository } from '@gitbutler/shared/branches/branchesPreview.svelte';
 	import { BranchStatus } from '@gitbutler/shared/branches/types';
@@ -14,12 +14,13 @@
 	import { Button, Select, SelectItem } from '@gitbutler/ui';
 
 	// Get authentication service and check if user is logged in
-	const authService = inject(AUTH_SERVICE);
 	const routes = inject(WEB_ROUTES_SERVICE);
+	const userService = inject(USER_SERVICE);
+	const user = userService.user;
 
-	// If there is no token (user not logged in), redirect to home
+	// If there is no user (user not logged in), redirect to home
 	$effect(() => {
-		if (!authService.token.current) {
+		if ($user === undefined) {
 			goto(routes.homePath());
 		}
 	});

apps/web/src/routes/(app)/[ownerSlug]/rules/+page.svelte

@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { goto } from '$app/navigation';
-	import { AUTH_SERVICE } from '$lib/auth/authService.svelte';
+	import { USER_SERVICE } from '$lib/user/userService';
 	import { inject } from '@gitbutler/core/context';
 	import { eventTimeStamp } from '@gitbutler/shared/branches/utils';
 	import Loading from '@gitbutler/shared/network/Loading.svelte';
@@ -11,12 +11,13 @@
 	import type { Rule } from '@gitbutler/shared/rules/types';
 
 	// Get authentication service and check if user is logged in
-	const authService = inject(AUTH_SERVICE);
 	const routes = inject(WEB_ROUTES_SERVICE);
+	const userService = inject(USER_SERVICE);
+	const user = userService.user;
 
-	// If there is no token (user not logged in), redirect to home
+	// If there is no user (user not logged in), redirect to home
 	$effect(() => {
-		if (!authService.token.current) {
+		if ($user === undefined) {
 			goto(routes.homePath());
 		}
 	});