Re-added test and default value setting for options

github-tools · May 4, 2019 · f2cfa93 · f2cfa93
1 parent 9f558aa
commit f2cfa93
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/Repository.js b/lib/Repository.js
@@ -187,6 +187,7 @@ class Repository extends Requestable {
     * @return {Promise} - the promise for the http request
     */
    listCommits(options, cb) {
+      options = options || {};
       if (typeof options === 'function') {
          cb = options;
          options = {};

diff --git a/test/repository.spec.js b/test/repository.spec.js
@@ -132,6 +132,18 @@ describe('Repository', function() {
          }));
       });
 
+      it('should list commits with null options', function(done) {
+         remoteRepo.listCommits(null, assertSuccessful(done, function(err, commits) {
+            expect(commits).to.be.an.array();
+            expect(commits.length).to.be.above(0);
+
+            expect(commits[0]).to.have.own('commit');
+            expect(commits[0]).to.have.own('author');
+
+            done();
+         }));
+      });
+
       it('should list commits with all options', function(done) {
          const since = new Date(2015, 0, 1);
          const until = new Date(2016, 0, 20);