Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to flag/clean lines that don't match code in the codebase anymore #148

Closed
mwachs5 opened this issue Oct 17, 2024 · 2 comments
Closed
Labels
enhancement New feature or request Stale

Comments

@mwachs5
Copy link

mwachs5 commented Oct 17, 2024

Is your feature request related to a problem?

If I have a useful entry in my CODEOWNERS file like:

/my/old/library @mwachs5

and then later I delete the directory, or rename it to

/my/new/library

There is nothing that flags the line as being 'dead' now. Since there is a limit to the size of the CODEOWNERS file, this could become a problem.

Describe the solution you'd like

This cleaning action could delete the dead lines.

I'd prefer to make that decoupled from the deletion of invalid users, since in our organization we'd prefer to have control over reassignment when we realize that the file has become outdated.

Describe alternatives you've considered

  • The way GitHub currently reports if the user is no longer present at the organization, thereby makign the CODEOWNERS file invalid, is fine. Though, it seems like since it is actually changes to the codebase (because files are handled by the repo) this could be done more synchronously with changes to the codebase.
  • a button one could click on the GUI for 'tell me whether this CODEOWNERS file meets certain criteria'
  • C/I check that prohibits invalidating changes to the CODEOWNERS file

Additional context

No response

@mwachs5 mwachs5 added the enhancement New feature or request label Oct 17, 2024
@mwachs5 mwachs5 changed the title Ability to flag lines that don't match code in the codebase anymore Ability to flag/clean lines that don't match code in the codebase anymore Oct 17, 2024
Copy link

github-actions bot commented Nov 8, 2024

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Nov 8, 2024
Copy link

This issue was closed because it has been stalled for 35 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

1 participant