Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate other GitHub variants when retrieving feature flags from GitHub API #2567

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Tolerate other GitHub variants when retrieving feature flags from GitHub API #2567

merged 3 commits into from
Oct 25, 2024

Conversation

NlightNFotis
Copy link
Member

Description

This PR introduces the capability to the GitHub API handler to tolerate other GitHub variants when retrieving feature flags.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@NlightNFotis NlightNFotis self-assigned this Oct 24, 2024
@NlightNFotis NlightNFotis requested a review from a team as a code owner October 24, 2024 14:13
aeisenberg
aeisenberg previously approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I didn't realize it was so easy. This looks like the right fix.

Before merging, can you do a quick check throughout the code to see if there's any other place we're missing GHE_DOTCOM?

henrymercer
henrymercer previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fotis!

@henrymercer henrymercer added the Rebuild Re-transpile JS & re-generate workflows label Oct 25, 2024
@github-actions github-actions bot removed the Rebuild Re-transpile JS & re-generate workflows label Oct 25, 2024
henrymercer
henrymercer approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

@NlightNFotis NlightNFotis merged commit 3aa7135 into main Oct 25, 2024
275 checks passed
@NlightNFotis NlightNFotis deleted the NlightNFotis/feature_flag_fix branch October 25, 2024 16:38
This was referenced Nov 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

@aeisenberg aeisenberg aeisenberg left review comments

Assignees

@NlightNFotis NlightNFotis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NlightNFotis @aeisenberg @henrymercer