Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 6d41b4a

Browse files
committedJan 23, 2025·
Python: fix some of the TODOs
1 parent d92acec commit 6d41b4a

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed
 

‎python/ql/lib/semmle/python/security/dataflow/WeakSensitiveDataHashingQuery.qll

+2-10
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,7 @@ module NormalHashFunction {
3434
sensitiveDataExtraStepForCalls(node1, node2)
3535
}
3636

37-
predicate observeDiffInformedIncrementalMode() {
38-
// TODO(diff-informed): Manually verify if config can be diff-informed.
39-
// ql/lib/semmle/python/security/dataflow/WeakSensitiveDataHashingQuery.qll:88: Flow call outside 'select' clause
40-
none()
41-
}
37+
predicate observeDiffInformedIncrementalMode() { any() }
4238
}
4339

4440
/** Global taint-tracking for detecting "use of a broken or weak cryptographic hashing algorithm on sensitive data" vulnerabilities. */
@@ -70,11 +66,7 @@ module ComputationallyExpensiveHashFunction {
7066
sensitiveDataExtraStepForCalls(node1, node2)
7167
}
7268

73-
predicate observeDiffInformedIncrementalMode() {
74-
// TODO(diff-informed): Manually verify if config can be diff-informed.
75-
// ql/lib/semmle/python/security/dataflow/WeakSensitiveDataHashingQuery.qll:95: Flow call outside 'select' clause
76-
none()
77-
}
69+
predicate observeDiffInformedIncrementalMode() { any() }
7870
}
7971

8072
/** Global taint-tracking for detecting "use of a broken or weak cryptographic hashing algorithm on passwords" vulnerabilities. */

‎python/ql/src/experimental/semmle/python/libraries/SmtpLib.qll

+1-3
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ module SmtpLib {
4040
}
4141

4242
predicate observeDiffInformedIncrementalMode() {
43-
// TODO(diff-informed): Manually verify if config can be diff-informed.
44-
// ql/src/experimental/semmle/python/libraries/SmtpLib.qll:91: Flow call outside 'select' clause
45-
none()
43+
none() // Used in library model
4644
}
4745
}
4846

0 commit comments

Comments
 (0)
Please sign in to comment.