Swift/CleartextStoragePreferencesQuery

swift/ql/src/queries/Security/CWE-312/CleartextStoragePreferences.ql

Author: d10c

swift/ql/lib/codeql/swift/security/CleartextStoragePreferencesQuery.qll

@@ -34,12 +34,9 @@ module CleartextStoragePreferencesConfig implements DataFlow::ConfigSig {
   predicate observeDiffInformedIncrementalMode() { any() }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    exists(DataFlow::Node cleanSink | result = cleanSink.getLocation() |
-      cleanSink = sink.(DataFlow::PostUpdateNode).getPreUpdateNode()
-      or
-      not sink instanceof DataFlow::PostUpdateNode and
-      cleanSink = sink
-    )
+    result = sink.(CleartextStoragePreferencesSink).getLocation()
+    or
+    result = sink.(DataFlow::PostUpdateNode).getPreUpdateNode().getLocation()
   }
 }