Skip to content

Commit 00fb352

Browse files
stephentoubCopilot
andcommitted
Skip in-process-only auth and telemetry E2E failures
CLI 1.0.81-2 no longer honors client-level GitHub tokens over the in-process (FFI) host, which resolves auth from the ambient environment instead, so every test that starts a client with its own token reports 'Not authenticated'. GitHub telemetry notifications are likewise not forwarded in-process. Use the existing skip_inprocess/SkipIfInProcess guards rather than disabling the tests outright: they keep running, and passing, over the default (stdio) transport, so coverage is retained. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 812b44f2-ef93-4b32-b051-c7092f612279
1 parent eae63f9 commit 00fb352

5 files changed

Lines changed: 35 additions & 0 deletions

File tree

go/internal/e2e/github_telemetry_e2e_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ import (
1212

1313
func TestGitHubTelemetryE2E(t *testing.T) {
1414
t.Run("should forward github telemetry for a live session", func(t *testing.T) {
15+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 does not forward GitHub telemetry notifications
16+
// over the in-process (FFI) host, mirroring the existing telemetry-configuration
17+
// limitation. Still covered by the default (stdio) transport.
18+
testharness.SkipIfInProcess(t, "GitHub telemetry forwarding is not honored in-process")
19+
1520
ctx := testharness.NewTestContext(t)
1621
ctx.ConfigureForTest(t)
1722

rust/tests/e2e/client.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,11 @@ async fn should_get_status() {
7979

8080
#[tokio::test]
8181
async fn should_get_authenticated_status() {
82+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 stopped honoring client-level GitHub tokens over the
83+
// in-process (FFI) host, which resolves auth from the ambient environment instead.
84+
if super::support::skip_inprocess("client-level GitHub tokens are not supported in-process") {
85+
return;
86+
}
8287
with_e2e_context("client", "should_get_authenticated_status", |ctx| {
8388
Box::pin(async move {
8489
ctx.set_default_copilot_user();
@@ -99,6 +104,11 @@ async fn should_get_authenticated_status() {
99104

100105
#[tokio::test]
101106
async fn should_list_models_when_authenticated() {
107+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 stopped honoring client-level GitHub tokens over the
108+
// in-process (FFI) host, which resolves auth from the ambient environment instead.
109+
if super::support::skip_inprocess("client-level GitHub tokens are not supported in-process") {
110+
return;
111+
}
102112
with_e2e_context("client", "should_list_models_when_authenticated", |ctx| {
103113
Box::pin(async move {
104114
ctx.set_default_copilot_user();

rust/tests/e2e/github_telemetry.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ use super::support::{DEFAULT_TEST_TOKEN, with_e2e_context_no_snapshot};
99

1010
#[tokio::test]
1111
async fn should_forward_github_telemetry_on_session_create() {
12+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 does not forward GitHub telemetry notifications over
13+
// the in-process (FFI) host, mirroring the existing telemetry-configuration limitation.
14+
if super::support::skip_inprocess("GitHub telemetry forwarding is not honored in-process") {
15+
return;
16+
}
1217
with_e2e_context_no_snapshot(|ctx| {
1318
Box::pin(async move {
1419
ctx.set_default_copilot_user();

rust/tests/e2e/provider_endpoint.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ async fn byok_provider_endpoint_returns_configured_endpoint() {
9191
#[tokio::test]
9292
#[allow(deprecated)]
9393
async fn capi_provider_endpoint_returns_resolved_credentials() {
94+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 stopped honoring client-level GitHub tokens over the
95+
// in-process (FFI) host, which resolves auth from the ambient environment instead.
96+
if super::support::skip_inprocess("client-level GitHub tokens are not supported in-process") {
97+
return;
98+
}
9499
with_e2e_context(
95100
"provider-endpoint",
96101
"capi_provider_endpoint_returns_resolved_credentials",

rust/tests/e2e/rpc_server.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ async fn should_call_rpc_ping_with_typed_params_and_result() {
4848

4949
#[tokio::test]
5050
async fn should_call_rpc_models_list_with_typed_result() {
51+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 stopped honoring client-level GitHub tokens over the
52+
// in-process (FFI) host, which resolves auth from the ambient environment instead.
53+
if super::support::skip_inprocess("client-level GitHub tokens are not supported in-process") {
54+
return;
55+
}
5156
with_e2e_context(
5257
"rpc_server",
5358
"should_call_rpc_models_list_with_typed_result",
@@ -77,6 +82,11 @@ async fn should_call_rpc_models_list_with_typed_result() {
7782

7883
#[tokio::test]
7984
async fn should_call_rpc_account_get_quota_when_authenticated() {
85+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 stopped honoring client-level GitHub tokens over the
86+
// in-process (FFI) host, which resolves auth from the ambient environment instead.
87+
if super::support::skip_inprocess("client-level GitHub tokens are not supported in-process") {
88+
return;
89+
}
8090
with_e2e_context(
8191
"rpc_server",
8292
"should_call_rpc_account_get_quota_when_authenticated",

0 commit comments

Comments
 (0)