Skip to content

Commit 06920e4

Browse files
joshspicerCopilot
andcommitted
Preserve legacy Python approve-all calls
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 08fdb39 commit 06920e4

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

python/copilot/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ class PermissionHandler:
378378
def approve_all(
379379
request: PermissionRequest, invocation: PermissionInvocation
380380
) -> PermissionRequestResult:
381-
if invocation["managed_settings_enabled"]:
381+
if invocation.get("managed_settings_enabled", False):
382382
raise RuntimeError("approve_all cannot be used when managed settings are enabled")
383383
if getattr(request, "managed_approval_required", False) is True:
384384
return PermissionNoResult()

python/test_managed_permissions.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from typing import Any
2+
13
import pytest
24

35
from copilot.rpc import PermissionDecisionApproveOnce, PermissionDecisionUserNotAvailable
@@ -58,13 +60,9 @@ def test_approve_all_leaves_managed_request_pending_when_session_flag_is_absent(
5860
managed_approval_required=True,
5961
)
6062

61-
assert isinstance(
62-
PermissionHandler.approve_all(
63-
request,
64-
{"session_id": "session-1", "managed_settings_enabled": False},
65-
),
66-
PermissionNoResult,
67-
)
63+
legacy_invocation: Any = {"session_id": "session-1"}
64+
65+
assert isinstance(PermissionHandler.approve_all(request, legacy_invocation), PermissionNoResult)
6866

6967

7068
async def test_legacy_permission_callback_rejects_no_result() -> None:

0 commit comments

Comments
 (0)