Address PR #1164 review feedback

  emitted from the loop correlate to a session in traces. Matches
  the pattern documented in the rust-coding-skill.

- README.md / embeddedcli.rs: correct the embedded-CLI documentation
  to match what build.rs and embeddedcli.rs actually do — archives
  come from the github/copilot-cli GitHub Releases, integrity is
  SHA-256 against SHA256SUMS.txt, and the runtime cache path is
  ~/.cache/copilot-sdk-{version}/copilot.

- test/scenarios/sessions/streaming/verify.sh: drop a duplicate
  '# Go: build' comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: tclem

rust/README.md

@@ -499,9 +499,9 @@ COPILOT_CLI_VERSION=1.0.15 cargo build
 
 ### How it works
 
-1. **Build time:** The SDK's `build.rs` detects `COPILOT_CLI_VERSION`, downloads the platform-appropriate binary from npm (`@github/copilot-{platform}`), verifies the tarball's SHA-512 integrity hash against npm's registry metadata, compresses with zstd, and embeds via `include_bytes!()`. No extra steps or tools needed — just the env var.
+1. **Build time:** The SDK's `build.rs` detects `COPILOT_CLI_VERSION`, downloads the platform-appropriate archive from the [`github/copilot-cli` GitHub Releases](https://github.com/github/copilot-cli/releases) (`copilot-{platform}.tar.gz` on macOS/Linux, `.zip` on Windows), verifies the archive's SHA-256 against the release's `SHA256SUMS.txt`, extracts the `copilot` binary, compresses it with zstd, and embeds via `include_bytes!()`. No extra steps or tools needed — just the env var.
 
-2. **Runtime:** On the first call to `copilot::resolve::copilot_binary()`, the embedded binary is lazily extracted to `~/.cache/copilot-sdk/copilot_{version}`, SHA-256 verified, and cached. Subsequent calls return the cached path.
+2. **Runtime:** On the first call to `copilot::resolve::copilot_binary()`, the embedded binary is lazily extracted to `~/.cache/copilot-sdk-{version}/copilot` (or `copilot.exe` on Windows), SHA-256 verified, and cached. Subsequent calls return the cached path.
 
 3. **Dev builds:** Without the env var, `build.rs` does nothing. The binary is resolved from PATH as usual — zero friction.
 

rust/src/embeddedcli.rs

@@ -34,8 +34,9 @@ pub fn bundled_version() -> Option<&'static str> {
 /// Returns the path to the installed CLI binary, lazily extracting on first call.
 ///
 /// When the SDK was built with `COPILOT_CLI_VERSION` set, this extracts the
-/// embedded binary to `~/.cache/copilot-sdk/copilot_{version}`, verifies the
-/// SHA-256 hash, and returns the path. Subsequent calls return the cached result.
+/// embedded binary to `~/.cache/copilot-sdk-{version}/copilot` (or
+/// `copilot.exe` on Windows), verifies the SHA-256 hash, and returns the
+/// path. Subsequent calls return the cached result.
 ///
 /// Returns `None` if no CLI was embedded at build time.
 pub fn path() -> Option<PathBuf> {

rust/src/session.rs

@@ -6,7 +6,7 @@ use std::time::Duration;
 use serde_json::Value;
 use tokio::sync::{Mutex, oneshot};
 use tokio::task::JoinHandle;
-use tracing::warn;
+use tracing::{Instrument, warn};
 
 use crate::generated::api_types::{
     PermissionDecision, PermissionDecisionApproveOnce, PermissionDecisionApproveOnceKind,
@@ -934,29 +934,33 @@ fn spawn_event_loop(
         mut requests,
     } = channels;
 
-    tokio::spawn(async move {
-        loop {
-            tokio::select! {
-                Some(notification) = notifications.recv() => {
-                    handle_notification(
-                        &session_id, &client, &handler, notification, &idle_waiter, &capabilities, &event_tx,
-                    ).await;
-                }
-                Some(request) = requests.recv() => {
-                    handle_request(
-                        &session_id, &client, &handler, hooks.as_deref(), transforms.as_deref(), request,
-                    ).await;
+    let span = tracing::error_span!("session_event_loop", session_id = %session_id);
+    tokio::spawn(
+        async move {
+            loop {
+                tokio::select! {
+                    Some(notification) = notifications.recv() => {
+                        handle_notification(
+                            &session_id, &client, &handler, notification, &idle_waiter, &capabilities, &event_tx,
+                        ).await;
+                    }
+                    Some(request) = requests.recv() => {
+                        handle_request(
+                            &session_id, &client, &handler, hooks.as_deref(), transforms.as_deref(), request,
+                        ).await;
+                    }
+                    else => break,
                 }
-                else => break,
+            }
+            // Channels closed — fail any pending send_and_wait.
+            if let Some(waiter) = idle_waiter.lock().await.take() {
+                let _ = waiter
+                    .tx
+                    .send(Err(Error::Session(SessionError::EventLoopClosed)));
             }
         }
-        // Channels closed — fail any pending send_and_wait.
-        if let Some(waiter) = idle_waiter.lock().await.take() {
-            let _ = waiter
-                .tx
-                .send(Err(Error::Session(SessionError::EventLoopClosed)));
-        }
-    })
+        .instrument(span),
+    )
 }
 
 fn extract_request_id(data: &Value) -> Option<RequestId> {

test/scenarios/sessions/streaming/verify.sh

@@ -111,7 +111,6 @@ check "TypeScript (build)"   bash -c "cd '$SCRIPT_DIR/typescript' && npm run bui
 check "Python (install)" bash -c "python3 -c 'import copilot' 2>/dev/null || (cd '$SCRIPT_DIR/python' && pip3 install -r requirements.txt --quiet 2>&1)"
 check "Python (syntax)"  bash -c "python3 -c \"import ast; ast.parse(open('$SCRIPT_DIR/python/main.py').read()); print('Syntax OK')\""
 
-# Go: build
 # Go: build
 check "Go (build)" bash -c "cd '$SCRIPT_DIR/go' && go build -o streaming-go . 2>&1"