Skip to content

Commit 5b010ab

Browse files
stephentoubCopilot
andcommitted
Name the exact blocked CLI build in skip markers
The skipped E2E tests are blocked by the prerelease build this PR pins, 1.0.81-2, not by 1.0.81 generally. Say so in the TODO markers and skip reasons so whoever re-enables them compares against the right build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 812b44f2-ef93-4b32-b051-c7092f612279
1 parent edd9f47 commit 5b010ab

7 files changed

Lines changed: 14 additions & 14 deletions

File tree

dotnet/test/E2E/RpcUiEphemeralQueryE2ETests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ namespace GitHub.Copilot.Test.E2E;
1919
public class RpcUiEphemeralQueryE2ETests(E2ETestFixture fixture, ITestOutputHelper output)
2020
: E2ETestBase(fixture, "rpc_ui_ephemeral_query", output)
2121
{
22-
// TODO(cli-1.0.81): CLI 1.0.81 fails session.ui.ephemeralQuery against the recorded
22+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 fails session.ui.ephemeralQuery against the recorded
2323
// snapshot ("Failed to get response from the AI model"). Re-enable once the runtime
2424
// fix ships.
25-
[Fact(Skip = "Blocked on CLI 1.0.81 session.ui.ephemeralQuery regression")]
25+
[Fact(Skip = "Blocked on CLI 1.0.81-2 session.ui.ephemeralQuery regression")]
2626
public async Task Should_Answer_Ephemeral_Query()
2727
{
2828
await using var session = await CreateSessionAsync();

go/internal/e2e/rpc_session_state_e2e_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -566,10 +566,10 @@ func TestRPCSessionStateE2E(t *testing.T) {
566566
})
567567

568568
t.Run("should update options and initialize session services", func(t *testing.T) {
569-
// TODO(cli-1.0.81): under CLI 1.0.81 this subtest issues model traffic before the
569+
// TODO(cli-1.0.81-2): under CLI 1.0.81-2 this subtest issues model traffic before the
570570
// replaying proxy is configured, so the proxy rejects it with "not yet initialized".
571571
// Re-enable once the runtime restores the previous option-update ordering.
572-
t.Skip("blocked on CLI 1.0.81 session option/service initialization ordering")
572+
t.Skip("blocked on CLI 1.0.81-2 session option/service initialization ordering")
573573
initialDirectory := createUniqueRPCWorkDirectory(t, ctx, "rpc-session-state-initial")
574574
optionsDirectory := createUniqueRPCWorkDirectory(t, ctx, "rpc-session-state-options")
575575
featureName := "rpc-session-state-" + randomHex(t)

nodejs/test/e2e/factory.e2e.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ it.skipIf(isInProcessTransport)(
9393
}
9494
);
9595

96-
// TODO(cli-1.0.81): the subagent request is rejected downstream under CLI 1.0.81, so the
96+
// TODO(cli-1.0.81-2): the subagent request is rejected downstream under CLI 1.0.81-2, so the
9797
// fixture reports didThrow: true. Re-enable once the runtime fix ships.
9898
it.skip(
9999
"forwards every declared subagent option to the runtime",

nodejs/test/e2e/tools.e2e.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe("Custom tools", async () => {
4545
expect(assistantMessage?.data.content).toContain("HELLO");
4646
});
4747

48-
// TODO(cli-1.0.81): CLI 1.0.81 stops servicing nested requests on the same stdio
48+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 stops servicing nested requests on the same stdio
4949
// connection while awaiting a tool handler, so calling session.history.clearContext
5050
// from inside a terminal tool deadlocks. Tracked as a runtime reentrancy regression;
5151
// re-enable once the fixed CLI ships.

rust/tests/e2e/rpc_mcp_lifecycle.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,10 @@ async fn should_stop_running_mcp_server() {
138138
.await;
139139
}
140140

141-
// TODO(cli-1.0.81): CLI 1.0.81 no longer installs an MCP config from the inline start
141+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 no longer installs an MCP config from the inline start
142142
// payload, so `session.mcp.startServer` reports "has no installed config to start".
143143
// Re-enable once the runtime fix ships.
144-
#[ignore = "blocked on CLI 1.0.81 MCP installed-config regression"]
144+
#[ignore = "blocked on CLI 1.0.81-2 MCP installed-config regression"]
145145
#[tokio::test]
146146
async fn should_start_and_restart_mcp_server() {
147147
super::support::with_shared_e2e_context(

rust/tests/e2e/rpc_ui_ephemeral_query.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
use github_copilot_sdk::rpc::UIEphemeralQueryRequest;
22

3-
// TODO(cli-1.0.81): CLI 1.0.81 fails session.ui.ephemeralQuery against the recorded
3+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 fails session.ui.ephemeralQuery against the recorded
44
// snapshot ("Failed to get response from the AI model"). Re-enable once the runtime
55
// fix ships.
6-
#[ignore = "blocked on CLI 1.0.81 session.ui.ephemeralQuery regression"]
6+
#[ignore = "blocked on CLI 1.0.81-2 session.ui.ephemeralQuery regression"]
77
#[tokio::test]
88
async fn should_answer_ephemeral_query() {
99
super::support::with_shared_e2e_context(

rust/tests/e2e/session_fs_sqlite.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -407,9 +407,9 @@ fn sqlite_session_config(
407407
.with_session_fs_provider(provider)
408408
}
409409

410-
// TODO(cli-1.0.81): CLI 1.0.81 hangs servicing the nested SQL tool request, so this test
410+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 hangs servicing the nested SQL tool request, so this test
411411
// times out. Re-enable once the runtime reentrancy fix ships.
412-
#[ignore = "blocked on CLI 1.0.81 nested tool-request servicing regression"]
412+
#[ignore = "blocked on CLI 1.0.81-2 nested tool-request servicing regression"]
413413
#[tokio::test]
414414
async fn should_route_sql_queries_through_the_sessionfs_sqlite_handler() {
415415
super::support::with_shared_e2e_context(
@@ -481,9 +481,9 @@ async fn should_route_sql_queries_through_the_sessionfs_sqlite_handler() {
481481
.await;
482482
}
483483

484-
// TODO(cli-1.0.81): CLI 1.0.81 hangs servicing the nested SQL tool request, so this test
484+
// TODO(cli-1.0.81-2): CLI 1.0.81-2 hangs servicing the nested SQL tool request, so this test
485485
// times out. Re-enable once the runtime reentrancy fix ships.
486-
#[ignore = "blocked on CLI 1.0.81 nested tool-request servicing regression"]
486+
#[ignore = "blocked on CLI 1.0.81-2 nested tool-request servicing regression"]
487487
#[tokio::test]
488488
async fn should_allow_subagents_to_use_sql_tool_via_inherited_sessionfs() {
489489
super::support::with_shared_e2e_context(

0 commit comments

Comments
 (0)