Skip to content

Commit 740d73b

Browse files
fix: drop invalid .js extension from vscode-jsonrpc/node import
vscode-jsonrpc (bumped to ^9.0.1 in this PR) only exports the './node' subpath (not './node.js') per its package.json exports map, so importing 'vscode-jsonrpc/node.js' failed at runtime with '"./node.js" is not exported under the conditions [...]'. This broke test/e2e/extension_env_access.e2e.test.ts on the nodejs ubuntu CI jobs. Fixed to match every other import site in the SDK, which already uses 'vscode-jsonrpc/node' without the extension. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 658713b commit 740d73b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

nodejs/test/e2e/extension_env_access.e2e.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
createMessageConnection,
1414
StreamMessageReader,
1515
StreamMessageWriter,
16-
} from "vscode-jsonrpc/node.js";
16+
} from "vscode-jsonrpc/node";
1717
import { approveAll } from "../../src/index.js";
1818
import { getSdkProtocolVersion } from "../../src/sdkProtocolVersion.js";
1919
import { createSdkTestContext, isInProcessTransport } from "./harness/sdkTestContext.js";

0 commit comments

Comments
 (0)